linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yordan Karadzhov <y.karadz@gmail.com>
To: Nicolas Fella <nicolas.fella@gmx.de>, linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] kernelshark: Set QApplication::desktopFileName
Date: Tue, 22 Mar 2022 13:32:36 +0200	[thread overview]
Message-ID: <113dd55a-1324-c3a7-7663-2e206e069a38@gmail.com> (raw)
In-Reply-To: <20220321225330.825082-1-nicolas.fella@gmx.de>



On 22.03.22 г. 0:53 ч., Nicolas Fella wrote:
> This is needed for properly associating the window with the desktop file.
> 
> This is needed for e.g. showing the correct icon in desktop environments.
> 
> Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
> ---
>   src/kernelshark.cpp | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/kernelshark.cpp b/src/kernelshark.cpp
> index 92bc1f1..c373f54 100644
> --- a/src/kernelshark.cpp
> +++ b/src/kernelshark.cpp
> @@ -56,6 +56,7 @@ int main(int argc, char **argv)
>   	int c;
> 
>   	QApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
> +	QApplication::setDesktopFileName("kernelshark");

Hi Nicolas,

Looking into the Qt documentation, it seems to me that the argument must be the desktop file name without the full path. 
And the name of the file is 'kernelshark.desktop'.

Thanks!
Yordan

>   	QApplication a(argc, argv);
> 
>   	KsMainWindow ks;
> --
> 2.35.1
> 

  reply	other threads:[~2022-03-22 11:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 22:53 [PATCH] kernelshark: Set QApplication::desktopFileName Nicolas Fella
2022-03-22 11:32 ` Yordan Karadzhov [this message]
2022-03-22 11:53   ` Nicolas Fella
2022-03-23  7:37     ` Yordan Karadzhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=113dd55a-1324-c3a7-7663-2e206e069a38@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=nicolas.fella@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).