From: Steven Rostedt <rostedt@goodmis.org>
To: Vladislav Valtchev <vladislav.valtchev@gmail.com>
Cc: y.karadz@gmail.com, linux-trace-devel@vger.kernel.org
Subject: Re: [RFC PATCH v3 5/9] trace-cmd: Move libparsevent *.c files in lib/pevent
Date: Wed, 13 Dec 2017 10:49:28 -0500 [thread overview]
Message-ID: <20171213104928.17c0f34c@gandalf.local.home> (raw)
In-Reply-To: <1513166659.2565.37.camel@gmail.com>
On Wed, 13 Dec 2017 14:04:19 +0200
Vladislav Valtchev <vladislav.valtchev@gmail.com> wrote:
> > > +
> > > +DEFAULT_TARGET = libparsevent.a
> > > +
> > > +OBJS =
> >
> > Is the above really necessary?
>
> DEFAULT_TARGET is just a label, I can remove it.
I didn't mean the DEFAULT_TARGET when I said "the above", I was just
referring to OBJS, which I now see that could be somewhat ambiguous in
what I meant.
> While OBJS = is a "coding style" thing in order to have all the
> objects added with +=, one per line.
I like the "+=" but do we really need to initialize it to nothing
first? Doesn't make work if you just simply remove the "OBJS =" blank
line, and a "OBJS += blah" will make OBJS equal to "blah" if OBJS
doesn't exist yet.
-- Steve
>
> How would you like the objects to be listed?
next prev parent reply other threads:[~2017-12-13 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171212162534.31144-1-vladislav.valtchev@gmail.com>
[not found] ` <20171212162534.31144-5-vladislav.valtchev@gmail.com>
[not found] ` <20171212190037.53710fa2@gandalf.local.home>
[not found] ` <1513171955.2565.42.camel@gmail.com>
2017-12-13 15:47 ` [RFC PATCH v3 4/9] trace-cmd: Extract part of Makefile in utils.mk Steven Rostedt
2017-12-18 15:29 ` Vladislav Valtchev
[not found] ` <20171212162534.31144-6-vladislav.valtchev@gmail.com>
[not found] ` <20171212192116.5e99d9aa@gandalf.local.home>
[not found] ` <1513166659.2565.37.camel@gmail.com>
2017-12-13 15:49 ` Steven Rostedt [this message]
2017-12-18 15:34 ` [RFC PATCH v3 5/9] trace-cmd: Move libparsevent *.c files in lib/pevent Vladislav Valtchev
2017-12-18 18:02 ` Steven Rostedt
[not found] ` <20171212162534.31144-10-vladislav.valtchev@gmail.com>
[not found] ` <20171212192911.0cd6aa14@gandalf.local.home>
[not found] ` <1513173046.2565.59.camel@gmail.com>
2017-12-13 15:51 ` [RFC PATCH v3 9/9] trace-cmd: Move GUI files in kernel-shark/ Steven Rostedt
[not found] ` <20171212193004.05efce2e@gandalf.local.home>
[not found] ` <1513173368.2565.64.camel@gmail.com>
2017-12-13 15:53 ` [RFC PATCH v3 0/9] trace-cmd: restructure of the source tree [incomplete] Steven Rostedt
2017-12-18 15:35 ` Vladislav Valtchev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213104928.17c0f34c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=vladislav.valtchev@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).