From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] trace-filter: Change the hashing function used when filtering
Date: Tue, 19 Jun 2018 18:54:08 -0400 [thread overview]
Message-ID: <20180619185408.58931c8f@gandalf.local.home> (raw)
In-Reply-To: <20180619132259.21387-2-y.karadz@gmail.com>
On Tue, 19 Jun 2018 16:22:59 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> The hashing function used in trace-filter-hash is changed.
> The new hashing functions is based on the Donald E. Knuth's
> Multiplicative hashing, suggested in his book "The Art of
> Computer Programming". This improves the performance, but
> also removes the restrictions resulting from using the
> Paul Hsieh's super fast hash, published under the terms of
> the GPL 2.0 license.
>
> Paul Hsieh's hash function, defined in trace-hash-local.h,
> is still used in trace-graph.c, trace-plot.c, trace-plot-cpu.c
> and trace-plot-task.c. Because trace-hash-local.h is no longer
> included in trace-filter-hash.h, it has to be included
> explicitly in these four source files.
>
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
I've applied these but haven't pushed them out yet. Which files need to
be changed from GPL to LGPL? Now that we have removed the GPL code from
the filter hash.
-- Steve
next prev parent reply other threads:[~2018-06-19 22:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 13:22 [PATCH v2 1/2] trace-filter: Change the naming convention used in trace-filter-hash Yordan Karadzhov (VMware)
2018-06-19 13:22 ` [PATCH v2 2/2] trace-filter: Change the hashing function used when filtering Yordan Karadzhov (VMware)
2018-06-19 22:54 ` Steven Rostedt [this message]
2018-06-20 11:48 ` Yordan Karadzhov (VMware)
2018-06-20 15:21 ` Steven Rostedt
2018-06-20 18:04 ` Yordan Karadzhov
2018-06-20 18:13 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619185408.58931c8f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).