From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] trace-filter: Change the hashing function used when filtering
Date: Wed, 20 Jun 2018 14:13:18 -0400 [thread overview]
Message-ID: <20180620141318.3381f6dc@gandalf.local.home> (raw)
In-Reply-To: <129b43b8-e526-b8b7-f581-144fd82d2dd1@Gmail.com>
On Wed, 20 Jun 2018 21:04:48 +0300
Yordan Karadzhov <y.karadz@gmail.com> wrote:
> My only reason for having the hash functions in the header is to make sure
> that the user will be aware that those are cheap and fast functions, but
> using
> those functions makes sense only in the case when we have relatively small
> number of items in the hash table. Nevertheless, If you prefer the
> implementation
> to be in the .c file this is OK.
Either that, or in a local header file. I don't think we need to export
this as part of libtracecmd.a
I'll make the changes.
Thanks!
-- Steve
prev parent reply other threads:[~2018-06-20 18:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 13:22 [PATCH v2 1/2] trace-filter: Change the naming convention used in trace-filter-hash Yordan Karadzhov (VMware)
2018-06-19 13:22 ` [PATCH v2 2/2] trace-filter: Change the hashing function used when filtering Yordan Karadzhov (VMware)
2018-06-19 22:54 ` Steven Rostedt
2018-06-20 11:48 ` Yordan Karadzhov (VMware)
2018-06-20 15:21 ` Steven Rostedt
2018-06-20 18:04 ` Yordan Karadzhov
2018-06-20 18:13 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620141318.3381f6dc@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).