From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=jM0/=JL=vger.kernel.org=linux-trace-devel-owner@goodmis.org>
Received: from mail.kernel.org ([198.145.29.99]:56848 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752203AbeFYQGi (ORCPT
        <rfc822;linux-trace-devel@vger.kernel.org>);
        Mon, 25 Jun 2018 12:06:38 -0400
Date: Mon, 25 Jun 2018 12:06:36 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 1/7] kernel-shark-qt: Add Cmake build system for the Qt
 based KernelShark
Message-ID: <20180625120636.2a5a7de0@gandalf.local.home>
In-Reply-To: <20180625150121.14291-2-y.karadz@gmail.com>
References: <20180625150121.14291-1-y.karadz@gmail.com>
        <20180625150121.14291-2-y.karadz@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-trace-devel-owner@vger.kernel.org
List-ID: <linux-trace-devel.vger.kernel.org>

On Mon, 25 Jun 2018 18:01:15 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> This patch adds in /kernel-shark-qt a simple CMake building
> infrastructure, to be used by the new, Qt-based version of
> KernelShark.

May want to add in the change log, something like this.

  Currently, this does not build anything. It is only to add
  the necessary infrastructure for the coming changes.

I can add it, so you don't need to send more code. Just an FYI, that if
there's something that is added for infrastructure, that doesn't really
do anything by itself, a brief note about that is usually expected.


> 
> diff --git a/kernel-shark-qt/build/deff.h.cmake b/kernel-shark-qt/build/deff.h.cmake
> new file mode 100644
> index 0000000..62e6b9e
> --- /dev/null
> +++ b/kernel-shark-qt/build/deff.h.cmake
> @@ -0,0 +1,20 @@
> + /**
> + *  \file    KsDeff.h
> + *  \brief   This File is generated by CMAKE
> + */
> +
> +// !-- Do Not Hand Edit - This File is generated by CMAKE --!

Is this generated? Do we need to add this in the commit, or can this
just be created during the setup?

-- Steve

> +
> +#ifndef _KS_CONFIG_H
> +#define _KS_CONFIG_H
> +
> +/** KernelShark Version number. */
> +#cmakedefine KS_VERSION_STRING "@KS_VERSION_STRING@"
> +
> +/** KernelShark source code path. */
> +#cmakedefine KS_DIR "@KS_DIR@"
> +
> +/** Location of the trace-cmd executable. */
> +#cmakedefine TRACECMD_BIN_DIR "@TRACECMD_BIN_DIR@"
> +
> +#endif // _KS_CONFIG_H