linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 5/7] kernel-shark-qt: Add a README file to trace-cmd/kernel-shark-qt
Date: Tue, 26 Jun 2018 11:18:26 -0400	[thread overview]
Message-ID: <20180626111826.0a19b441@gandalf.local.home> (raw)
In-Reply-To: <d336e69a-0e95-4cba-d8a5-0756a150b2c2@gmail.com>

On Tue, 26 Jun 2018 17:51:07 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:


> > I'm not so sure how useful this "third party software" section is. I
> > think it's pretty obvious that gcc, c++ and cmake will be needed.
> >   
> 
> I would like to have here instructions how to build the code on a 
> default out-of-the-box installation of Ubuntu or Fedora. I agree that it 
> doesn't make sense as it is right now, but it will start making sense 
> when we start adding more and more dependencies.

OK, I'm just worried about maintaining it.

> > Note, after all the code is in the repo, I expect to have the top level
> > Makefile, do all the cmake work for the user.
> >   
> 
> Do you mean, you want to completely remove this README file?
> 

We may not need to, if it can still be built separately. But ideally, I
want people to simply type "make gui" at the top level and it does
everything (cmake and all). I don't think that will be to difficult to
implement. I was actually planning on doing the implementation myself.

-- Steve

  reply	other threads:[~2018-06-26 15:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 15:01 [PATCH 0/7] Introduce the very basic part of the C API of KS-1.0 Yordan Karadzhov (VMware)
2018-06-25 15:01 ` [PATCH 1/7] kernel-shark-qt: Add Cmake build system for the Qt based KernelShark Yordan Karadzhov (VMware)
2018-06-25 16:06   ` Steven Rostedt
2018-06-26 14:23     ` Yordan Karadzhov (VMware)
2018-06-25 15:01 ` [PATCH 3/7] kernel-shark-qt: Add API for loading trace.dat files Yordan Karadzhov (VMware)
2018-06-25 18:30   ` Steven Rostedt
2018-06-26 14:47     ` Yordan Karadzhov (VMware)
2018-06-26 15:16       ` Steven Rostedt
2018-06-26 15:26         ` Yordan Karadzhov (VMware)
2018-06-25 15:01 ` [PATCH 4/7] kernel-shark-qt: Add an example showing how to load trace data Yordan Karadzhov (VMware)
2018-06-25 18:34   ` Steven Rostedt
2018-06-25 15:01 ` [PATCH 5/7] kernel-shark-qt: Add a README file to trace-cmd/kernel-shark-qt Yordan Karadzhov (VMware)
2018-06-25 18:38   ` Steven Rostedt
2018-06-26 14:51     ` Yordan Karadzhov (VMware)
2018-06-26 15:18       ` Steven Rostedt [this message]
2018-06-25 15:01 ` [PATCH 6/7] kernel-shark-qt: Add filtering to the C API of KernelShark Yordan Karadzhov (VMware)
2018-06-25 19:07   ` Steven Rostedt
2018-06-25 15:01 ` [PATCH 7/7] kernel-shark-qt: Add an example showing how to filter trace data Yordan Karadzhov (VMware)
     [not found] ` <20180625150121.14291-3-y.karadz@gmail.com>
2018-06-25 16:09   ` [PATCH 2/7] kernel-shark-qt: Automatic generation of doxygen documentation Steven Rostedt
2018-06-26 14:29     ` Yordan Karadzhov (VMware)
2018-06-26 15:00       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180626111826.0a19b441@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).