From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v3 3/9] kernel-shark-qt: Add API for loading trace.dat files
Date: Fri, 29 Jun 2018 14:34:58 -0400 [thread overview]
Message-ID: <20180629143458.07e50efa@gandalf.local.home> (raw)
In-Reply-To: <20180629142911.722d9314@gandalf.local.home>
On Fri, 29 Jun 2018 14:29:11 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> Other than that, the patch looks good, as it looks like you did
> everything I asked. I would have done the rearranging myself, but since
> the realloc and calloc above need error checks, you can submit this one
> again.
>
> The first two patches are fine, and I'll pull them in so no need to
> resubmit those.
>
> I'll continue to review the other patches, and if I don't see anything
> wrong with them, then you only need to update this one patch.
The rest of the patches look good. Just resend a v4 of this patch.
Thanks!
-- Steve
next prev parent reply other threads:[~2018-06-29 18:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 15:25 [PATCH v3 0/9] Introduce the basic part of the C API of KS-1.0 Yordan Karadzhov (VMware)
2018-06-29 15:25 ` [PATCH v3 1/9] kernel-shark-qt: Add Cmake build system for the Qt based KernelShark Yordan Karadzhov (VMware)
2018-06-29 15:25 ` [PATCH v3 2/9] kernel-shark-qt: Automatic generation of doxygen documentation Yordan Karadzhov (VMware)
2018-06-29 15:25 ` [PATCH v3 3/9] kernel-shark-qt: Add API for loading trace.dat files Yordan Karadzhov (VMware)
2018-06-29 18:29 ` Steven Rostedt
2018-06-29 18:34 ` Steven Rostedt [this message]
2018-06-29 15:25 ` [PATCH v3 4/9] kernel-shark-qt: Add an example showing how to load trace data Yordan Karadzhov (VMware)
2018-06-29 15:25 ` [PATCH v3 5/9] kernel-shark-qt: Add a README file to trace-cmd/kernel-shark-qt Yordan Karadzhov (VMware)
2018-06-29 15:25 ` [PATCH v3 6/9] kernel-shark-qt: Add filtering to the C API of KernelShark Yordan Karadzhov (VMware)
2018-06-29 15:25 ` [PATCH v3 7/9] kernel-shark-qt: Add an example showing how to filter trace data Yordan Karadzhov (VMware)
2018-06-29 15:25 ` [PATCH v3 8/9] kernel-shark-qt: Add Advanced filter to the session context Yordan Karadzhov (VMware)
2018-06-29 15:25 ` [PATCH v3 9/9] kernel-shark-qt: Add example of advanded filtering Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629143458.07e50efa@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).