Re: [PATCH 2/3] kernel-shark-qt: Consolidate load_data_entries and load_data_records

[Steven Rostedt <rostedt@goodmis.org>]

On Fri, 6 Jul 2018 14:21:04 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> >   
> > > +				entry = &temp_rec->entry;
> > > +				kshark_set_entry_values(kshark_ctx, rec, entry);    
> > 
> > Maybe the call of kshark_add_task() can be moved to 
> > kshark_load_data_entries()
> > Just to be consistent with kshark_load_data_records()  
> 
> The problem is that "rec" is freed. That was required as part of the
> speed up.

Ah, you said kshark_add_task(), I read it as kshark_set_entry_values().
I'll look at it. But an FYI on replying. When making comments, one
usually references the code above, not below, which is where I got
confused.

Thanks!

-- Steve


> 
> >   
> > > +				task = kshark_add_task(kshark_ctx, entry->pid);
> > > +				if (!task) {
> > > +					free_record(rec);
> > > +					goto fail;
> > > +				}