From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 1/3] kernel-shark-qt: Change the type of the fields in struct kshark_entry
Date: Fri, 3 Aug 2018 16:07:57 +0300 [thread overview]
Message-ID: <20180803130759.31858-1-y.karadz@gmail.com> (raw)
This patch aims to increase the max value limits of the "pid" and
"cpu" fields of struct kshark_entry. The type of the field "visible"
is changed as well, but this is done just to provide optimal packing.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
kernel-shark-qt/src/libkshark.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel-shark-qt/src/libkshark.h b/kernel-shark-qt/src/libkshark.h
index 2e26552..0ad31c0 100644
--- a/kernel-shark-qt/src/libkshark.h
+++ b/kernel-shark-qt/src/libkshark.h
@@ -42,16 +42,16 @@ struct kshark_entry {
* kshark_filter_masks to check the level of visibility/invisibility
* of the entry.
*/
- uint8_t visible;
+ uint16_t visible;
/** The CPU core of the record. */
- uint8_t cpu;
+ int16_t cpu;
/** The PID of the task the record was generated. */
- int16_t pid;
+ int32_t pid;
/** Unique Id ot the trace event type. */
- int event_id;
+ int32_t event_id;
/** The offset into the trace file, used to find the record. */
uint64_t offset;
--
2.17.1
next reply other threads:[~2018-08-03 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 13:07 Yordan Karadzhov (VMware) [this message]
2018-08-03 13:07 ` [PATCH 2/3] kernel-shark-qt: Change the input argument of kshark_dump_entry() to const Yordan Karadzhov (VMware)
2018-08-03 13:07 ` [PATCH 3/3] kernel-shark-qt: In the Doxygen doc. add spacing after @brief and @param Yordan Karadzhov (VMware)
2018-08-03 18:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803130759.31858-1-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).