linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 02/24] trace-cmd: Rename struct pevent_record to struct tep_record
Date: Mon, 20 Aug 2018 23:01:00 -0400	[thread overview]
Message-ID: <20180820230100.75f63b21@vmware.local.home> (raw)
In-Reply-To: <20180820143505.11525-3-tz.stoyanov@gmail.com>


Hi Tzvetomir,

Note, these were not pulled from the tip git tree. As the subject isn't
the same, nor is the change log (as the change log has links and Cc's
as the tags).

I know this is a bit tedious, but by pulling from tip, we see what in
trace-cmd was pulled from upstream.

You can do this by going to the tip tree:

 $ cd linux-tip.git
 $ git format-patch cbc49b25b9cf2~1..cbc49b25b9cf2 tools/lib/

Then editing the patch file paths to match trace-cmd's paths.

 $ cd ../trace-cmd.git
 $ git am <patch>

Then take this patch:

 $ patch -p1 < this.patch

Skip the parts that say:

  Reversed (or previously applied) patch detected!  Assume -R? [n] 

As they are already applied, and you should end up with the same
changes but with the original upstream patch.

To make sure of this, do this from a different branch

 $ git checkout -b upstream-changes <branch where trace-cmd upstream is>

apply the changes from tip, and then you can do

 $ git diff upstream-changes <the branch that has this patch series>

and it should be the same.

Does this make sense?

-- Steve


On Mon, 20 Aug 2018 17:34:43 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:

> In order to make libtraceevent into a proper library, variables, data
> structures and functions require a unique prefix to prevent name space
> conflicts. That prefix will be "tep_" and not "pevent_". This changes
> the struct pevent_record to struct tep_record.
> 
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
> ---
>  include/trace-cmd/trace-cmd.h      | 48 ++++++++--------
>  include/traceevent/event-parse.h   | 44 +++++++--------
>  kernel-shark-qt/src/libkshark.c    | 28 +++++-----
>  kernel-shark-qt/src/libkshark.h    |  4 +-
>  kernel-shark/include/trace-graph.h | 18 +++---
>  kernel-shark/include/trace-gui.h   |  4 +-
>  kernel-shark/kernel-shark.c        |  4 +-
>  kernel-shark/trace-dialog.c        |  4 +-
>  kernel-shark/trace-graph.c         | 16 +++---
>  kernel-shark/trace-plot-cpu.c      | 30 +++++-----
>  kernel-shark/trace-plot-task.c     | 60 ++++++++++----------
>  kernel-shark/trace-plot.c          |  4 +-
>  kernel-shark/trace-view-main.c     |  2 +-
>  kernel-shark/trace-view-store.c    | 14 ++---
>  lib/trace-cmd/trace-ftrace.c       | 20 +++----
>  lib/trace-cmd/trace-input.c        | 88 +++++++++++++++---------------
>  lib/traceevent/event-parse.c       | 36 ++++++------
>  lib/traceevent/parse-filter.c      | 24 ++++----
>  plugins/plugin_blk.c               |  2 +-
>  plugins/plugin_function.c          |  2 +-
>  plugins/plugin_futex.c             |  2 +-
>  plugins/plugin_hrtimer.c           |  4 +-
>  plugins/plugin_kmem.c              |  2 +-
>  plugins/plugin_kvm.c               | 14 ++---
>  plugins/plugin_mac80211.c          |  4 +-
>  plugins/plugin_sched_switch.c      |  6 +-
>  plugins/plugin_tlb.c               |  2 +-
>  python/ctracecmd.i                 | 12 ++--
>  tracecmd/include/trace-local.h     |  4 +-
>  tracecmd/trace-hist.c              | 20 +++----
>  tracecmd/trace-mem.c               |  8 +--
>  tracecmd/trace-profile.c           | 36 ++++++------
>  tracecmd/trace-read.c              | 34 ++++++------
>  tracecmd/trace-record.c            |  4 +-
>  tracecmd/trace-split.c             | 12 ++--
>  tracecmd/trace-stream.c            |  2 +-
>  36 files changed, 309 insertions(+), 309 deletions(-)
> 

  reply	other threads:[~2018-08-21  6:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 14:34 [PATCH 00/24] trace-cmd: rename variables, data structures and functions in lib/traceevent Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 02/24] trace-cmd: Rename struct pevent_record to struct tep_record Tzvetomir Stoyanov (VMware)
2018-08-21  3:01   ` Steven Rostedt [this message]
2018-08-20 14:34 ` [PATCH 03/24] trace-cmd: Rename pevent plugin related APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 04/24] trace-cmd: Rename pevent alloc / free APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 05/24] trace-cmd: Rename pevent find APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 06/24] trace-cmd: Rename pevent parse APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 07/24] trace-cmd: Rename pevent print APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 08/24] trace-cmd: Rename pevent_read_number_* APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 09/24] trace-cmd: Rename pevent_register_* APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 10/24] trace-cmd: Rename pevent_set_* APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 11/24] trace-cmd: Rename pevent_traceevent_* APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 12/24] trace-cmd: Rename enum pevent_flag to enum tep_flag Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 13/24] trace-cmd: Rename enunm pevent_errno to enum tep_errno Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 14/24] trace-cmd: Rename pevent_function* APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 15/24] trace-cmd: Rename traceevent_* APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 16/24] trace-cmd: Rename pevent_filter* APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 17/24] trace-cmd: Rename pevent_register / unregister APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:34 ` [PATCH 18/24] trace-cmd: Rename pevent_data_ APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:35 ` [PATCH 19/24] trace-cmd: Rename pevent field APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:35 ` [PATCH 20/24] trace-cmd: Rename pevent_find_* APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:35 ` [PATCH 21/24] trace-cmd: Rename various pevent get/set/is APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:35 ` [PATCH 22/24] trace-cmd: Rename internal parser related APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:35 ` [PATCH 23/24] trace-cmd: Rename various pevent APIs Tzvetomir Stoyanov (VMware)
2018-08-20 14:35 ` [PATCH 24/24] trace-cmd: Rename static variables and functions in event-parse.c Tzvetomir Stoyanov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180820230100.75f63b21@vmware.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).