From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] kernel-shark-qt: Add C++ API for drawing of Graphs
Date: Fri, 24 Aug 2018 10:50:01 -0400 [thread overview]
Message-ID: <20180824105001.40064c74@gandalf.local.home> (raw)
In-Reply-To: <20180824142116.21339-4-y.karadz@gmail.com>
On Fri, 24 Aug 2018 17:21:15 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> + /*
> + * Check the content of the very firs bin and see if the CPU is
I haven't really looked too much at this patch yet, but this spelling
stood out. Seems your 't' key is not working well when typing "first
bin". There's several places that have that ;-)
-- Steve
> + * active.
> + */
> + bin = 0;
> + get_pid(bin);
> + if (pidFront >= 0) {
> + /*
> + * The CPU is active and this is a regular process.
> + * Set this bin.
> + */
> + set_bin(bin);
> + } else {
> + /*
> + * No data from this CPU in the very firs bin. Use the Lower
> + * Overflow Bin to retrieve the Process Id (if any). First
> + * get the Pid back, ignoring the filters.
> + */
next prev parent reply other threads:[~2018-08-24 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 14:21 [PATCH v2 0/4] Add drawing instrumentation to be used by the Qt-based KernelShark Yordan Karadzhov (VMware)
2018-08-24 14:21 ` [PATCH v2 1/4] kernel-shark-qt: Add OpenGL/GLUT as a third party dependency Yordan Karadzhov (VMware)
2018-08-24 14:21 ` [PATCH v2 2/4] kernel-shark-qt: Add basic instruments for OpenGL plotting Yordan Karadzhov (VMware)
2018-08-24 14:21 ` [PATCH v2 3/4] kernel-shark-qt: Add C++ API for drawing of Graphs Yordan Karadzhov (VMware)
2018-08-24 14:50 ` Steven Rostedt [this message]
2018-08-24 20:27 ` Yordan Karadzhov (VMware)
2018-08-24 14:21 ` [PATCH v2 4/4] kernel-shark-qt: Add an example showing how to draw shapes and Graphs Yordan Karadzhov (VMware)
2018-08-24 15:23 ` Steven Rostedt
2018-08-24 21:19 ` Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824105001.40064c74@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).