From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v3 21/24] tools lib traceevent: Rename various pevent get/set/is APIs
Date: Mon, 27 Aug 2018 09:17:54 -0400 [thread overview]
Message-ID: <20180827091754.3f832e87@gandalf.local.home> (raw)
In-Reply-To: <20180827081759.17297-22-tz.stoyanov@gmail.com>
On Mon, 27 Aug 2018 11:17:56 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> diff --git a/kernel-shark/trace-graph.c b/kernel-shark/trace-graph.c
> index 808b2f3..88870c1 100644
> --- a/kernel-shark/trace-graph.c
> +++ b/kernel-shark/trace-graph.c
> @@ -1133,7 +1133,7 @@ int trace_graph_check_sched_switch(struct graph_info *ginfo,
> * First time through, register any missing
> * comm / pid mappings.
> */
> - if (!pevent_pid_is_registered(ginfo->pevent, *pid))
> + if (!tep_find_event_by_record(ginfo->pevent, *pid))
Hmm, this isn't just a name change, but a change in function. Did you
mean this?
-- Steve
> tep_register_comm(ginfo->pevent,
> *comm, *pid);
> }
next prev parent reply other threads:[~2018-08-27 17:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 8:17 [PATCH v3 00/24] trace-cmd: rename variables, data structures and functions in lib/traceevent Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 02/24] tools lib traceevent, perf tools: Rename 'struct pevent_record' to 'struct tep_record' Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 03/24] tools lib traceevent, perf tools: Rename pevent plugin related APIs Tzvetomir Stoyanov (VMware)
2018-08-28 9:10 ` [PATCH v3.5 " Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 04/24] tools lib traceevent, perf tools: Rename pevent alloc / free APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 05/24] tools lib traceevent, perf tools: Rename pevent find APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 06/24] tools lib traceevent, perf tools: Rename pevent parse APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 07/24] tools lib traceevent, perf tools: Rename pevent print APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 08/24] tools lib traceevent, perf tools: Rename pevent_read_number_* APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 09/24] tools lib traceevent, perf tools: Rename pevent_register_* APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 10/24] tools lib traceevent, perf tools: Rename pevent_set_* APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 11/24] tools lib traceevent, perf tools: Rename traceevent_* APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 12/24] tools lib traceevent, perf tools: Rename 'enum pevent_flag' to 'enum tep_flag' Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 13/24] tools lib traceevent, tools lib lockdep: Rename 'enum pevent_errno' to 'enum tep_errno' Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 14/24] tools lib traceevent: Rename pevent_function* APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 15/24] tools lib traceevent, perf tools: Rename traceevent_plugin_* APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 16/24] tools lib traceevent: Rename pevent_filter* APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 17/24] tools lib traceevent: Rename pevent_register / unregister APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 18/24] tools lib traceevent: Rename pevent_data_ APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 19/24] tools lib traceevent: Rename pevent field APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 20/24] tools lib traceevent: Rename pevent_find_* APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 21/24] tools lib traceevent: Rename various pevent get/set/is APIs Tzvetomir Stoyanov (VMware)
2018-08-27 13:17 ` Steven Rostedt [this message]
2018-08-27 13:31 ` Ceco
2018-08-27 13:36 ` Steven Rostedt
2018-08-28 9:09 ` [PATCH v3.5 " Tzvetomir Stoyanov (VMware)
2018-08-28 22:18 ` Steven Rostedt
2018-08-27 8:17 ` [PATCH v3 22/24] tools lib traceevent: Rename internal parser related APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 23/24] tools lib traceevent: Rename various pevent APIs Tzvetomir Stoyanov (VMware)
2018-08-27 8:17 ` [PATCH v3 24/24] tools lib traceevent: Rename static variables and functions in event-parse.c Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827091754.3f832e87@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).