linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 2/4] kernel-shark-qt: Restore the alignment in libkshark-configio.c
Date: Wed, 29 Aug 2018 12:32:27 -0400	[thread overview]
Message-ID: <20180829123227.7ce86b23@gandalf.local.home> (raw)
In-Reply-To: <20180829162927.20200-2-y.karadz@gmail.com>

On Wed, 29 Aug 2018 19:29:25 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> The alignment of the function arguments has to be fixed after the
> naming convention changes.
> 
> This version of the patch contains a number of improvements suggested
> by Steven Rostedt. Thanks Steven!

I don't think I need credit for a whitespace fix patch ;-)

-- Steve

> 
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
>  kernel-shark-qt/src/libkshark-configio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel-shark-qt/src/libkshark-configio.c b/kernel-shark-qt/src/libkshark-configio.c
> index 484da93..cdc8c76 100644
> --- a/kernel-shark-qt/src/libkshark-configio.c
> +++ b/kernel-shark-qt/src/libkshark-configio.c
> @@ -1034,7 +1034,7 @@ static bool kshark_adv_filters_to_json(struct kshark_context *kshark_ctx,
>  
>  	for (i = 0; events[i]; i++) {
>  		str = tep_filter_make_string(adv_filter,
> -						events[i]->id);
> +					     events[i]->id);
>  		if (!str)
>  			continue;
>  
> @@ -1137,7 +1137,7 @@ static bool kshark_adv_filters_from_json(struct kshark_context *kshark_ctx,
>  			 json_object_get_string(jcond));
>  
>  		ret = tep_filter_add_filter_str(adv_filter,
> -						   filter_str);
> +						filter_str);
>  		if (ret < 0)
>  			goto fail;
>  	}
> @@ -1149,7 +1149,7 @@ static bool kshark_adv_filters_from_json(struct kshark_context *kshark_ctx,
>  	char error_str[200];
>  	int error_status =
>  		tep_strerror(kshark_ctx->pevent, ret, error_str,
> -							 sizeof(error_str));
> +						      sizeof(error_str));
>  
>  	if (error_status == 0)
>  		fprintf(stderr, "filter failed due to: %s\n", error_str);

  reply	other threads:[~2018-08-29 20:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 16:29 [PATCH 1/4] kernel-shark-qt: Change "pevent_" to "tep_" in Doxygen Yordan Karadzhov (VMware)
2018-08-29 16:29 ` [PATCH 2/4] kernel-shark-qt: Restore the alignment in libkshark-configio.c Yordan Karadzhov (VMware)
2018-08-29 16:32   ` Steven Rostedt [this message]
2018-08-29 16:35     ` Yordan Karadzhov (VMware)
2018-08-29 16:29 ` [PATCH 3/4] kernel-shark-qt: Remove TODO comment in kshark_load_data_entries() Yordan Karadzhov (VMware)
2018-08-29 16:29 ` [PATCH 4/4] kernel-shark-qt: Fix Doxygen doc. for libkshark-model.c Yordan Karadzhov (VMware)
2018-08-29 16:34   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829123227.7ce86b23@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).