Re: [PATCH 1/7] kernel-shark-qt: Add plugin infrastructure to be used by the Qt-baset KS.

[Steven Rostedt <rostedt@goodmis.org>]

On Wed, 29 Aug 2018 19:42:18 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> This patch adds infrastructure for loading/unloading of plugins. Each
> plugin is coupled to a specific type of trace event and is allowed to
> perform two types of actions.
> 
> The first action is executed once for each kshark_entry only at the time
> when the data is loaded. This action can modify (even completely rewrite)
> the content of the kshark_entrys generated from the trace events having
> the type of the plugin.
> 
> The second action can add graphical elements on top of the existing
> graphs generated by the Vis. model. This will become clear in the

What's a "Vis. model"?

I'm assuming that you mean "Visualization model"? If so, please avoid
using abbreviated names in change logs. It only leads to confusion.

Thanks!

-- Steve

> following patches. This action is executed once for each graph and
> this is happening every time when the Vis. model changes its state.
> It turns that this second plugin-specific action (callback function)
> is very powerful and can be used not only for drawing. It has an
> access (via the pointer to the model descriptor object) to the
> entire array of kshark_entries, hence it can be used to perform
> arbitrary modifications in the data.
> 
> The plugin infrastructure of the Qt-baset KernelShark reuses the system
> of macros for loading/unloading, implemented for the original GTK version.
> 
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
>