From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 3/4] kernel-shark-qt: Remove TODO comment in kshark_load_data_entries()
Date: Wed, 29 Aug 2018 19:29:26 +0300 [thread overview]
Message-ID: <20180829162927.20200-3-y.karadz@gmail.com> (raw)
In-Reply-To: <20180829162927.20200-1-y.karadz@gmail.com>
The problem described by the TODO message was fixed, but we forgot
to remove the message itself.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
kernel-shark-qt/src/libkshark.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/kernel-shark-qt/src/libkshark.c b/kernel-shark-qt/src/libkshark.c
index 1b7e544..b4a76ae 100644
--- a/kernel-shark-qt/src/libkshark.c
+++ b/kernel-shark-qt/src/libkshark.c
@@ -712,13 +712,6 @@ ssize_t kshark_load_data_entries(struct kshark_context *kshark_ctx,
if (*data_rows)
free(*data_rows);
- /*
- * TODO: Getting the records separately slows this function
- * down, instead of just accessing the records when
- * setting up the kernel entries. But this keeps the
- * code simplier. We should revisit to see if we can
- * bring back the performance.
- */
total = get_records(kshark_ctx, &rec_list, type);
if (total < 0)
goto fail;
--
2.17.1
next prev parent reply other threads:[~2018-08-29 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 16:29 [PATCH 1/4] kernel-shark-qt: Change "pevent_" to "tep_" in Doxygen Yordan Karadzhov (VMware)
2018-08-29 16:29 ` [PATCH 2/4] kernel-shark-qt: Restore the alignment in libkshark-configio.c Yordan Karadzhov (VMware)
2018-08-29 16:32 ` Steven Rostedt
2018-08-29 16:35 ` Yordan Karadzhov (VMware)
2018-08-29 16:29 ` Yordan Karadzhov (VMware) [this message]
2018-08-29 16:29 ` [PATCH 4/4] kernel-shark-qt: Fix Doxygen doc. for libkshark-model.c Yordan Karadzhov (VMware)
2018-08-29 16:34 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829162927.20200-3-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).