From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] kernel-shark-qt: Add "-O2" compiler flag
Date: Mon, 17 Sep 2018 13:15:22 -0400 [thread overview]
Message-ID: <20180917131522.0c9f6d5e@gandalf.local.home> (raw)
In-Reply-To: <20180917142942.7975-1-y.karadz@gmail.com>
On Mon, 17 Sep 2018 17:29:41 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> "-O2" compiler option is added to both C and C++ compiler flags.
Can you add -g as well. I know that somewhat contradicts the -O2 flag,
but it is also useful for debugging (even with optimization).
We can also add a debug option to not compile with -O2, but that can be
dealt with later.
-- Steve
>
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
> kernel-shark-qt/CMakeLists.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel-shark-qt/CMakeLists.txt b/kernel-shark-qt/CMakeLists.txt
> index 0187eb4..7769604 100644
> --- a/kernel-shark-qt/CMakeLists.txt
> +++ b/kernel-shark-qt/CMakeLists.txt
> @@ -23,8 +23,8 @@ find_package(GLUT)
> set(LIBRARY_OUTPUT_PATH "${KS_DIR}/lib")
> set(EXECUTABLE_OUTPUT_PATH "${KS_DIR}/bin")
>
> -set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -pthread")
> -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++11 -pthread")
> +set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -O2 -pthread")
> +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -O2 -std=c++11 -pthread")
>
> include_directories(${KS_DIR}/src/
> ${KS_DIR}/build/src/
prev parent reply other threads:[~2018-09-17 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 14:29 [PATCH 1/2] kernel-shark-qt: Add "-O2" compiler flag Yordan Karadzhov (VMware)
2018-09-17 14:29 ` [PATCH 2/2] kernel-shark-qt: Fix all problems revealed after adding " Yordan Karadzhov (VMware)
2018-09-17 17:15 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917131522.0c9f6d5e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).