From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH v5 5/8] kernel-shark-qt: Remove the TODO action in kshark_read_at()
Date: Thu, 20 Sep 2018 19:55:41 +0300 [thread overview]
Message-ID: <20180920165544.17579-6-y.karadz@gmail.com> (raw)
In-Reply-To: <20180920165544.17579-1-y.karadz@gmail.com>
The TODO message states that we have to understand why racecmd_read_at()
is not thread-safe and see if this can be fixed. We now know why and we
know that this cannot be fixed.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
kernel-shark-qt/src/libkshark.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel-shark-qt/src/libkshark.c b/kernel-shark-qt/src/libkshark.c
index 3635b48..506511d 100644
--- a/kernel-shark-qt/src/libkshark.c
+++ b/kernel-shark-qt/src/libkshark.c
@@ -842,9 +842,8 @@ struct tep_record *kshark_read_at(struct kshark_context *kshark_ctx,
uint64_t offset)
{
/*
- * It turns that tracecmd_read_at() is not thread-safe.
- * TODO: Understand why and see if this can be fixed.
- * For the time being use a mutex to protect the access.
+ * Calling tracecmd_read_at() is not thread-safe. Use a mutex to
+ * protect the access.
*/
pthread_mutex_lock(&kshark_ctx->input_mutex);
--
2.17.1
next prev parent reply other threads:[~2018-09-20 22:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 16:55 [PATCH v5 0/8] Add infrastructure for plugins Yordan Karadzhov (VMware)
2018-09-20 16:55 ` [PATCH v5 1/8] kernel-shark-qt: Add plugin infrastructure to be used by the Qt-baset KS Yordan Karadzhov (VMware)
2018-09-20 16:55 ` [PATCH v5 2/8] kernel-shark-qt: Add Plugin event handlers to session Yordan Karadzhov (VMware)
2018-09-20 16:55 ` [PATCH v5 3/8] kernel-shark-qt: Add C++/C conversion for args of a plugin draw function Yordan Karadzhov (VMware)
2018-09-20 16:55 ` [PATCH v5 4/8] kernel-shark-qt: Make kshark_read_at() non-static Yordan Karadzhov (VMware)
2018-09-20 16:55 ` Yordan Karadzhov (VMware) [this message]
2018-09-20 22:05 ` [PATCH v5 5/8] kernel-shark-qt: Remove the TODO action in kshark_read_at() Steven Rostedt
2018-09-20 16:55 ` [PATCH v5 6/8] kernel-shark-qt: Add src/plugins dir. to hold the source code of the plugins Yordan Karadzhov (VMware)
2018-09-20 16:55 ` [PATCH v5 7/8] kernel-shark-qt: Tell Doxygen to enter ../src/plugins/ Yordan Karadzhov (VMware)
2018-09-20 16:55 ` [PATCH v5 8/8] kernel-shark-qt: Add a plugin for sched events Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920165544.17579-6-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).