* [PATCH] trace-cmd: Remove unused <pthread.h> includes.
@ 2018-09-21 12:30 Slavomir Kaslev
2018-09-21 13:30 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Slavomir Kaslev @ 2018-09-21 12:30 UTC (permalink / raw)
To: rostedt; +Cc: linux-trace-devel
There are several <pthread.h> includes lurking eventhough trace-cmd
makes no use of threading. This patch gets rid of them.
Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
---
tracecmd/trace-output.c | 1 -
tracecmd/trace-read.c | 1 -
tracecmd/trace-record.c | 1 -
tracecmd/trace-restore.c | 1 -
tracecmd/trace-split.c | 1 -
5 files changed, 5 deletions(-)
diff --git a/tracecmd/trace-output.c b/tracecmd/trace-output.c
index ff7b198..e439c44 100644
--- a/tracecmd/trace-output.c
+++ b/tracecmd/trace-output.c
@@ -14,7 +14,6 @@
#include <sys/stat.h>
#include <sys/wait.h>
#include <sys/mman.h>
-#include <pthread.h>
#include <fcntl.h>
#include <unistd.h>
#include <ctype.h>
diff --git a/tracecmd/trace-read.c b/tracecmd/trace-read.c
index 02f0ce8..35d70c3 100644
--- a/tracecmd/trace-read.c
+++ b/tracecmd/trace-read.c
@@ -14,7 +14,6 @@
#include <sys/stat.h>
#include <sys/wait.h>
#include <sys/mman.h>
-#include <pthread.h>
#include <fcntl.h>
#include <signal.h>
#include <unistd.h>
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index 5a1d2a0..ce550a2 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -24,7 +24,6 @@
#endif
#endif
#include <netdb.h>
-#include <pthread.h>
#include <fcntl.h>
#include <unistd.h>
#include <ctype.h>
diff --git a/tracecmd/trace-restore.c b/tracecmd/trace-restore.c
index 1544cf2..b649cf4 100644
--- a/tracecmd/trace-restore.c
+++ b/tracecmd/trace-restore.c
@@ -14,7 +14,6 @@
#include <sys/stat.h>
#include <sys/wait.h>
#include <sys/mman.h>
-#include <pthread.h>
#include <fcntl.h>
#include <signal.h>
#include <unistd.h>
diff --git a/tracecmd/trace-split.c b/tracecmd/trace-split.c
index cabcc3d..5b2fc4f 100644
--- a/tracecmd/trace-split.c
+++ b/tracecmd/trace-split.c
@@ -15,7 +15,6 @@
#include <sys/stat.h>
#include <sys/wait.h>
#include <sys/mman.h>
-#include <pthread.h>
#include <fcntl.h>
#include <unistd.h>
#include <ctype.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] trace-cmd: Remove unused <pthread.h> includes.
2018-09-21 12:30 [PATCH] trace-cmd: Remove unused <pthread.h> includes Slavomir Kaslev
@ 2018-09-21 13:30 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2018-09-21 13:30 UTC (permalink / raw)
To: Slavomir Kaslev; +Cc: linux-trace-devel
On Fri, 21 Sep 2018 15:30:27 +0300
Slavomir Kaslev <kaslevs@vmware.com> wrote:
> There are several <pthread.h> includes lurking eventhough trace-cmd
> makes no use of threading. This patch gets rid of them.
>
> Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
> ---
>
Thanks Slavomir!
Those includes look to be a relic of a past design. I think I started
with threads, and then went to forking processes. That's how the
pthread header got there, and then cut & paste let it spread ;-)
-- Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-21 19:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-21 12:30 [PATCH] trace-cmd: Remove unused <pthread.h> includes Slavomir Kaslev
2018-09-21 13:30 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).