From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:49688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727077AbeJDBoi (ORCPT ); Wed, 3 Oct 2018 21:44:38 -0400 Date: Wed, 3 Oct 2018 14:54:58 -0400 From: Steven Rostedt To: Yordan Karadzhov Cc: Linux Trace Devel Subject: Re: Some more updates for KernelShark Message-ID: <20181003145458.165568c6@gandalf.local.home> In-Reply-To: <20181003141552.1600bfa9@gandalf.local.home> References: <20181003141552.1600bfa9@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org List-ID: On Wed, 3 Oct 2018 14:15:52 -0400 Steven Rostedt wrote: > Hi Yordan, > > I'm using your latest KS for doing some real work (sched_deadline patch > review so it's perfect). Two nits: > > In the event description window, instead of "Cpu" it should be "CPU" as > it is a proper acronym. > > Second, can you do the same thing in the task plot view that you did in > the CPU view. That is, when the mouse is not over an event, the > description should show what CPU the task is on, like you did for the > CPU plot, where it showed what task the mouse is over. Another issue I see. The colors of the CPUs for task plots need to stay consistent. That is, CPU-1 should be the same color on all task plots. This is required to see why a task was preempted. -- Steve