Some more updates for KernelShark

Some more updates for KernelShark

[Steven Rostedt]

Hi Yordan,

I'm using your latest KS for doing some real work (sched_deadline patch
review so it's perfect). Two nits:

In the event description window, instead of "Cpu" it should be "CPU" as
it is a proper acronym.

Second, can you do the same thing in the task plot view that you did in
the CPU view. That is, when the mouse is not over an event, the
description should show what CPU the task is on, like you did for the
CPU plot, where it showed what task the mouse is over.

Thanks!

-- Steve

Re: Some more updates for KernelShark

[Steven Rostedt]

On Wed, 3 Oct 2018 14:15:52 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> Hi Yordan,
> 
> I'm using your latest KS for doing some real work (sched_deadline patch
> review so it's perfect). Two nits:
> 
> In the event description window, instead of "Cpu" it should be "CPU" as
> it is a proper acronym.
> 
> Second, can you do the same thing in the task plot view that you did in
> the CPU view. That is, when the mouse is not over an event, the
> description should show what CPU the task is on, like you did for the
> CPU plot, where it showed what task the mouse is over.


Another issue I see. The colors of the CPUs for task plots need to stay
consistent. That is, CPU-1 should be the same color on all task plots.
This is required to see why a task was preempted.

-- Steve

Re: Some more updates for KernelShark

[Steven Rostedt]

On Wed, 3 Oct 2018 14:54:58 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 3 Oct 2018 14:15:52 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > Hi Yordan,
> > 
> > I'm using your latest KS for doing some real work (sched_deadline patch
> > review so it's perfect). Two nits:
> > 
> > In the event description window, instead of "Cpu" it should be "CPU" as
> > it is a proper acronym.
> > 
> > Second, can you do the same thing in the task plot view that you did in
> > the CPU view. That is, when the mouse is not over an event, the
> > description should show what CPU the task is on, like you did for the
> > CPU plot, where it showed what task the mouse is over.  
> 
> 
> Another issue I see. The colors of the CPUs for task plots need to stay
> consistent. That is, CPU-1 should be the same color on all task plots.
> This is required to see why a task was preempted.

Ah, I see what is done. You have the color of the task in the task
plot. The colors in the task plots need to be of the CPUs they
represent, not the color of the task. We need to see how a task is
migrating.

Another enhancement (not required for 1.0 as the above requests are),
is to have the designated color of the tasks be the background of the
text of the tasks name in the left. And we can do the same for the CPUs.

-- Steve

Re: Some more updates for KernelShark

[Steven Rostedt]

On Wed, 3 Oct 2018 14:57:40 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> Another enhancement (not required for 1.0 as the above requests are),
> is to have the designated color of the tasks be the background of the
> text of the tasks name in the left. And we can do the same for the CPUs.

Another non 1.0 enhancement is a "back" button. After doing a zoom with
a dragging of the mouse, a back button would bring you back to the zoom
before you did the drag.

That is, several times I zoom in with the mouse (quick zoom) and then
want to come back out to where I did before that quick zoom, but
unfortunately there's no quick way to do that :-/

-- Steve