From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: Yordan Karadzhov <ykaradzhov@vmware.com>,
"linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] kernel-shark-qt: Add kshark_get_X_easy() functions.
Date: Fri, 5 Oct 2018 11:44:05 -0400 [thread overview]
Message-ID: <20181005114405.365ba90e@gandalf.local.home> (raw)
In-Reply-To: <ad5dcd71-aa99-f2d0-f586-8f8af9e03bab@gmail.com>
On Fri, 5 Oct 2018 18:27:20 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> If the value of "entry->pid" has been changed then the new value will be
> used when plotting graphs and we do not want to change this.
> However, we still want to be able to retrieve the original value. The
> description of the function explains that it will return the original value.
Right. I wanted to figure out why we have two values for pid?
OK, just clarifying what was the intent.
Please send v3 with the other updates.
Thanks!
-- Steve
next prev parent reply other threads:[~2018-10-05 22:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 13:59 [PATCH v2 0/5] Final preparation before adding the KernelShark GUI Yordan Karadzhov
2018-10-01 13:59 ` [PATCH v2 1/5] kernel-shark-qt: Add kshark_get_X_easy() functions Yordan Karadzhov
2018-10-02 20:44 ` Steven Rostedt
2018-10-03 7:34 ` Yordan Karadzhov
2018-10-05 14:30 ` Yordan Karadzhov (VMware)
2018-10-05 14:46 ` Steven Rostedt
2018-10-05 15:27 ` Yordan Karadzhov (VMware)
2018-10-05 15:44 ` Steven Rostedt [this message]
2018-10-01 13:59 ` [PATCH v2 2/5] kernel-shark-qt: Add kshark_convert_nano() function Yordan Karadzhov
2018-10-02 21:09 ` Steven Rostedt
2018-10-01 13:59 ` [PATCH v2 3/5] kernel-shark-qt: Add functions for fast clearing of the filters Yordan Karadzhov
2018-10-01 13:59 ` [PATCH v2 4/5] kernel-shark-qt: Rename the Cmake-generated header file Yordan Karadzhov
2018-10-01 13:59 ` [PATCH v2 5/5] kernel-shark-qt: Fix a bug in kshark_data_collection_alloc() Yordan Karadzhov
2018-10-02 21:18 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005114405.365ba90e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).