From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org,
Tzvetomir Stoyanov <tstoyanov@vmware.com>
Subject: Re: [PATCH v2 0/4] Add basic components to be used by the Qt GUI
Date: Wed, 10 Oct 2018 21:09:24 -0400 [thread overview]
Message-ID: <20181010210924.171370f4@vmware.local.home> (raw)
In-Reply-To: <20181010201015.23824-1-ykaradzhov@vmware.com>
On Wed, 10 Oct 2018 23:10:11 +0300
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> This series of patches introduces the first components of the Qt-based
> KernelShark GUI. It includes some basic utils, as well as various small
> widgets and dialogues used by the GUI. The GUI itself will be introdused
> in the following series.
>
> Yordan Karadzhov (VMware) (4):
> kernel-shark-qt: Add Qt as a third party dependency.
> kernel-shark-qt: Add KernalShark Utils
> kernel-shark-qt: Add Widgets Lib
> kernel-shark-qt: Add widget demo example.
The series looks good, but there's one problem. I've applied
Tzvetomir's latest patch that abstracts tep_handle, and causes your code
now to not build.
Can you pull my latest code and rebase these patches (I see nothing
wrong wtih them), but make sure they build at each step?
Thanks!
-- Steve
>
> kernel-shark-qt/CMakeLists.txt | 8 +
> kernel-shark-qt/README | 6 +-
> kernel-shark-qt/build/deff.h.cmake | 16 +
> kernel-shark-qt/examples/CMakeLists.txt | 4 +
> kernel-shark-qt/examples/widgetdemo.cpp | 158 +++++
> kernel-shark-qt/src/CMakeLists.txt | 22 +
> kernel-shark-qt/src/KsUtils.cpp | 594 ++++++++++++++++
> kernel-shark-qt/src/KsUtils.hpp | 233 +++++++
> kernel-shark-qt/src/KsWidgetsLib.cpp | 878 ++++++++++++++++++++++++
> kernel-shark-qt/src/KsWidgetsLib.hpp | 385 +++++++++++
> 10 files changed, 2303 insertions(+), 1 deletion(-)
> create mode 100644 kernel-shark-qt/examples/widgetdemo.cpp
> create mode 100644 kernel-shark-qt/src/KsUtils.cpp
> create mode 100644 kernel-shark-qt/src/KsUtils.hpp
> create mode 100644 kernel-shark-qt/src/KsWidgetsLib.cpp
> create mode 100644 kernel-shark-qt/src/KsWidgetsLib.hpp
>
prev parent reply other threads:[~2018-10-11 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:10 [PATCH v2 0/4] Add basic components to be used by the Qt GUI Yordan Karadzhov
2018-10-10 20:10 ` [PATCH v2 1/4] kernel-shark-qt: Add Qt as a third party dependency Yordan Karadzhov
2018-10-10 20:10 ` [PATCH v2 2/4] kernel-shark-qt: Add KernalShark Utils Yordan Karadzhov
2018-10-10 20:10 ` [PATCH v2 3/4] kernel-shark-qt: Add Widgets Lib Yordan Karadzhov
2018-10-10 20:10 ` [PATCH v2 4/4] kernel-shark-qt: Add widget demo example Yordan Karadzhov
2018-10-11 1:09 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010210924.171370f4@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tstoyanov@vmware.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).