From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:34692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbeJKIeP (ORCPT ); Thu, 11 Oct 2018 04:34:15 -0400 Date: Wed, 10 Oct 2018 21:09:24 -0400 From: Steven Rostedt To: Yordan Karadzhov Cc: linux-trace-devel@vger.kernel.org, Tzvetomir Stoyanov Subject: Re: [PATCH v2 0/4] Add basic components to be used by the Qt GUI Message-ID: <20181010210924.171370f4@vmware.local.home> In-Reply-To: <20181010201015.23824-1-ykaradzhov@vmware.com> References: <20181010201015.23824-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org List-ID: On Wed, 10 Oct 2018 23:10:11 +0300 Yordan Karadzhov wrote: > This series of patches introduces the first components of the Qt-based > KernelShark GUI. It includes some basic utils, as well as various small > widgets and dialogues used by the GUI. The GUI itself will be introdused > in the following series. > > Yordan Karadzhov (VMware) (4): > kernel-shark-qt: Add Qt as a third party dependency. > kernel-shark-qt: Add KernalShark Utils > kernel-shark-qt: Add Widgets Lib > kernel-shark-qt: Add widget demo example. The series looks good, but there's one problem. I've applied Tzvetomir's latest patch that abstracts tep_handle, and causes your code now to not build. Can you pull my latest code and rebase these patches (I see nothing wrong wtih them), but make sure they build at each step? Thanks! -- Steve > > kernel-shark-qt/CMakeLists.txt | 8 + > kernel-shark-qt/README | 6 +- > kernel-shark-qt/build/deff.h.cmake | 16 + > kernel-shark-qt/examples/CMakeLists.txt | 4 + > kernel-shark-qt/examples/widgetdemo.cpp | 158 +++++ > kernel-shark-qt/src/CMakeLists.txt | 22 + > kernel-shark-qt/src/KsUtils.cpp | 594 ++++++++++++++++ > kernel-shark-qt/src/KsUtils.hpp | 233 +++++++ > kernel-shark-qt/src/KsWidgetsLib.cpp | 878 ++++++++++++++++++++++++ > kernel-shark-qt/src/KsWidgetsLib.hpp | 385 +++++++++++ > 10 files changed, 2303 insertions(+), 1 deletion(-) > create mode 100644 kernel-shark-qt/examples/widgetdemo.cpp > create mode 100644 kernel-shark-qt/src/KsUtils.cpp > create mode 100644 kernel-shark-qt/src/KsUtils.hpp > create mode 100644 kernel-shark-qt/src/KsWidgetsLib.cpp > create mode 100644 kernel-shark-qt/src/KsWidgetsLib.hpp >