From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] tools/lib/traceevent: Rename struct cmdline to struct tep_cmdline
Date: Mon, 19 Nov 2018 09:13:38 -0500 [thread overview]
Message-ID: <20181119091338.43665df1@gandalf.local.home> (raw)
In-Reply-To: <20181119125255.19155-1-tstoyanov@vmware.com>
On Mon, 19 Nov 2018 12:53:08 +0000
Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:
> @@ -250,9 +250,9 @@ int tep_pid_is_registered(struct tep_handle *pevent, int pid)
> static int add_new_comm(struct tep_handle *pevent,
> const char *comm, int pid, bool override)
> {
> - struct cmdline *cmdlines = pevent->cmdlines;
> - struct cmdline *cmdline;
> - struct cmdline key;
> + struct tep_cmdline *cmdlines = pevent->cmdlines;
> + struct tep_cmdline *cmdline;
> + struct tep_cmdline key;
> char *new_comm;
>
Hi Tzvetomir,
This part failed for me, and I'm curious to know why. The code I have,
has the variable cmdline as "const struct cmdline", but the patch does
not. Was this added to a different change?
Thanks!
-- Steve
prev parent reply other threads:[~2018-11-20 0:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 12:53 [PATCH] tools/lib/traceevent: Rename struct cmdline to struct tep_cmdline Tzvetomir Stoyanov
2018-11-19 14:13 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119091338.43665df1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).