From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:45122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbeLKM3z (ORCPT ); Tue, 11 Dec 2018 07:29:55 -0500 Date: Tue, 11 Dec 2018 09:29:52 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: LKML , Linux Trace Devel , Jiri Olsa , Ingo Molnar , Namhyung Kim Subject: Re: [PATCH] tools/lib/traceevent: Fix processing of dereferenced args in bprintk events Message-ID: <20181211122952.GC14480@kernel.org> References: <20181210134522.3f71e2ca@gandalf.local.home> <20181210184807.GA26445@kernel.org> <20181210162621.2050475a@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181210162621.2050475a@gandalf.local.home> Sender: linux-trace-devel-owner@vger.kernel.org List-ID: Em Mon, Dec 10, 2018 at 04:26:21PM -0500, Steven Rostedt escreveu: > On Mon, 10 Dec 2018 15:48:07 -0300 > Arnaldo Carvalho de Melo wrote: > > > Em Mon, Dec 10, 2018 at 01:45:22PM -0500, Steven Rostedt escreveu: > > > From: "Steven Rostedt (VMware)" > > > > > > In the case that a bprintk event has a dereferenced pointer that is stored > > > as a string, and there's more values to process (more args), the arg was not > > > updated to point to the next arg after processing the dereferenced pointer, > > > and it screwed up what was to be displayed. > > > > Thanks, applied. > > > > > Cc: stable@vger.kernel.org > > > Fixes: 7db96bb49629 ("tools lib traceevent: Handle new pointer processing of bprint strings") > > Arnaldo, > > It seems that I cut and pasted the sha1 of the "fixes" part wrong. Can > you add a "3". That is, the above should have been: 37db96bb49629 Done, git rebase -i + reword -> push -f'ed :-) https://git.kernel.org/acme/c/1e862fa6b4e9 - Arnaldo > Thanks, > > -- Steve > > > > > > Signed-off-by: Steven Rostedt (VMware) > > > --- > > > tools/lib/traceevent/event-parse.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > > > index 3692f29fee46..70144b98141c 100644 > > > --- a/tools/lib/traceevent/event-parse.c > > > +++ b/tools/lib/traceevent/event-parse.c > > > @@ -4970,6 +4970,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct tep_e > > > > > > if (arg->type == TEP_PRINT_BSTRING) { > > > trace_seq_puts(s, arg->string.string); > > > + arg = arg->next; > > > break; > > > } > > > > > > -- > > > 2.19.1 > > -- - Arnaldo