linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 0/8] More modifications toward KS 1.0
Date: Fri, 14 Dec 2018 12:10:02 -0500	[thread overview]
Message-ID: <20181214121002.4524dab3@gandalf.local.home> (raw)
In-Reply-To: <20181214125212.9637-1-ykaradzhov@vmware.com>

On Fri, 14 Dec 2018 12:52:33 +0000
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:

> This series of patches contains the last (hopefully) modifications
> needed before releasing KernelShark 1.0.
> 
> This is the version 2 of this series of patches. The major changes
> from v1 are in patches 1-3 (new patches). These patches aim to address
> the deadlock problem reported by Steven.
> 
> Yordan Karadzhov (8):
>   kernel-shark-qt: Lock completely the searching panel when searching
>   kernel-shark-qt: Fix a simple bug in KsTraceViewer::_searchReset()
>   kernel-shark-qt: Make the parallelized search stoppable
>   kernel-shark-qt: Avoid spurious searches
>   kernel-shark-qt: Create "Apply filter XX" checkboxes in KsUtils
>   kernel-shark-qt: Improve the KsQuickContextMenu
>   kernel-shark-qt: Update the documentation link
>   kernel-shark-qt: Version 1.0.0
> 

One thing I found annoying, and I'm not sure how to stop this, but the
menu can be awfully touchy. When I'm on the table, and right click
(not hold, just click), it will open up the menu and then select
whatever menu item that the mouse was on, usually hiding the row I'm on.

One solution is to have the mouse be on something that it can not
select immediately. Like "Pointer menu".

Speaking of which, when selecting on the graph, not on an event, where
the menu is:

"Plots 
  Remove [CPU 0]"

the menu is way above the mouse. We probably want the menu to pop up
where the mouse is over "Plots".

-- Steve
  

  parent reply	other threads:[~2018-12-14 17:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 12:52 [PATCH v2 0/8] More modifications toward KS 1.0 Yordan Karadzhov
2018-12-14 12:52 ` [PATCH v2 1/8] kernel-shark-qt: Lock completely the searching panel when searching Yordan Karadzhov
2018-12-14 14:50   ` Steven Rostedt
2018-12-14 14:52     ` Steven Rostedt
2018-12-14 12:52 ` [PATCH v2 2/8] kernel-shark-qt: Fix a simple bug in KsTraceViewer::_searchReset() Yordan Karadzhov
2018-12-14 12:52 ` [PATCH v2 3/8] kernel-shark-qt: Make the parallelized search stoppable Yordan Karadzhov
2018-12-14 17:17   ` Steven Rostedt
2018-12-17 17:02     ` Yordan Karadzhov (VMware)
2018-12-14 12:52 ` [PATCH v2 4/8] kernel-shark-qt: Avoid spurious searches Yordan Karadzhov
2018-12-14 12:52 ` [PATCH v2 5/8] kernel-shark-qt: Create "Apply filter XX" checkboxes in KsUtils Yordan Karadzhov
2018-12-14 17:01   ` Steven Rostedt
2018-12-17 17:44     ` Yordan Karadzhov (VMware)
2018-12-14 12:52 ` [PATCH v2 6/8] kernel-shark-qt: Improve the KsQuickContextMenu Yordan Karadzhov
2018-12-14 12:52 ` [PATCH v2 7/8] kernel-shark-qt: Update the documentation link Yordan Karadzhov
2018-12-14 12:52 ` [PATCH v2 8/8] kernel-shark-qt: Version 1.0.0 Yordan Karadzhov
2018-12-14 17:10 ` Steven Rostedt [this message]
2018-12-17 17:11   ` [PATCH v2 0/8] More modifications toward KS 1.0 Yordan Karadzhov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214121002.4524dab3@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=ykaradzhov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).