From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: fix deletion of histogram triggers
Date: Tue, 18 Dec 2018 18:25:22 -0500 [thread overview]
Message-ID: <20181218182522.3d601a7e@gandalf.local.home> (raw)
In-Reply-To: <20181218103928.18345-1-tstoyanov@vmware.com>
On Tue, 18 Dec 2018 12:39:28 +0200
Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:
> This patch fixes the clear_trigger() function to delete
> configured histograms. Unlike other triggers, histograms
> must be deleted specifying the whole trigger string.
>
> Signed-off-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Applied. Thanks Tzvetomir!
-- Steve
> ---
> tracecmd/trace-record.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
> index a9bcd8d..37a2d1d 100644
> --- a/tracecmd/trace-record.c
> +++ b/tracecmd/trace-record.c
> @@ -1680,7 +1680,7 @@ static void clear_trigger(const char *file)
> * to the file for each trigger.
> */
> do {
> - len = find_trigger(file, trigger+1, BUFSIZ-1, 1);
> + len = find_trigger(file, trigger+1, BUFSIZ-1, 3);
> if (len)
> write_trigger(file, trigger);
> } while (len);
prev parent reply other threads:[~2018-12-18 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 10:39 [PATCH] trace-cmd: fix deletion of histogram triggers Tzvetomir Stoyanov
2018-12-18 23:25 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218182522.3d601a7e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).