linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	"linux-trace-devel@vger.kernel.org" 
	<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2] plugin python: Adjust the handling after PyRun_String() failed
Date: Tue, 15 Jan 2019 22:39:27 -0500	[thread overview]
Message-ID: <20190115223927.0e6aad61@vmware.local.home> (raw)
In-Reply-To: <1493261758-32597-1-git-send-email-treeze.taeung@gmail.com>

On Thu, 27 Apr 2017 11:55:58 +0900
Taeung Song <treeze.taeung@gmail.com> wrote:

> Even though PyRun_String() failed,
> just 0 will be returned but we need to return -1
> that means error status, so fix it.

Ug, I just noticed this patch floating in the flood of my INBOX.

I just applied it, and will be pushing it out soon.

Thanks, and I'm really sorry for not seeing it.

-- Steve

> 
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
>  plugin_python.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/plugin_python.c b/plugin_python.c
> index 2997679..c283ed7 100644
> --- a/plugin_python.c
> +++ b/plugin_python.c
> @@ -55,7 +55,7 @@ static int load_plugin(struct pevent *pevent, const char *path,
>  
>  	free(load);
>  
> -	return 0;
> +	return res ? 0 : -1;
>  }
>  
>  int PEVENT_PLUGIN_LOADER(struct pevent *pevent)


           reply	other threads:[~2019-01-16  3:39 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1493261758-32597-1-git-send-email-treeze.taeung@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190115223927.0e6aad61@vmware.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=treeze.taeung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).