From: Tzvetomir Stoyanov <tstoyanov@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH 3/7] trace-cmd: Fixed logic in tracecmd_read_page_record()
Date: Wed, 16 Jan 2019 21:18:34 +0200 [thread overview]
Message-ID: <20190116191838.32127-4-tstoyanov@vmware.com> (raw)
In-Reply-To: <20190116191838.32127-1-tstoyanov@vmware.com>
Fixed the logic in tracecmd_read_page_record() when
searching for the next event in the event from the
ring buffer.
Signed-off-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
---
lib/trace-cmd/trace-input.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index de15d4b..c2b993a 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -1688,18 +1688,22 @@ tracecmd_read_page_record(struct tep_handle *pevent, void *page, int size,
goto out_free;
}
- do {
+ ptr = kbuffer_read_event(kbuf, &ts);
+ while (ptr < last_record->data) {
ptr = kbuffer_next_event(kbuf, NULL);
if (!ptr)
break;
- } while (ptr < last_record->data);
+ if (ptr == last_record->data)
+ break;
+ }
if (ptr != last_record->data) {
warning("tracecmd_read_page_record: could not find last_record");
goto out_free;
}
- }
+ ptr = kbuffer_next_event(kbuf, &ts);
+ } else
+ ptr = kbuffer_read_event(kbuf, &ts);
- ptr = kbuffer_read_event(kbuf, &ts);
if (!ptr)
goto out_free;
--
2.20.1
next prev parent reply other threads:[~2019-01-16 19:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 19:18 [PATCH 0/7] trace-cmd [POC]: Timestamps sync using PTP-like algorithm, relying on vsock events Tzvetomir Stoyanov
2019-01-16 19:18 ` [PATCH 1/7] trace-cmd: Implemented new lib API: tracecmd_local_events_system() Tzvetomir Stoyanov
2019-01-21 9:02 ` Steven Rostedt
2019-01-16 19:18 ` [PATCH 2/7] trace-cmd: Added new option in trace.dat file for negative time offsets Tzvetomir Stoyanov
2019-01-21 9:08 ` Steven Rostedt
2019-01-22 13:28 ` Tzvetomir Stoyanov
2019-01-16 19:18 ` Tzvetomir Stoyanov [this message]
2019-01-21 9:09 ` [PATCH 3/7] trace-cmd: Fixed logic in tracecmd_read_page_record() Steven Rostedt
2019-01-22 13:36 ` Tzvetomir Stoyanov
2019-01-16 19:18 ` [PATCH 4/7] trace-cmd: Added implementation of htonll() and ntohll() Tzvetomir Stoyanov
2019-01-16 19:18 ` [PATCH 5/7] trace-cmd: Added user configured clock to the record context Tzvetomir Stoyanov
2019-01-21 9:19 ` Steven Rostedt
2019-01-22 13:43 ` Tzvetomir Stoyanov
2019-01-22 14:14 ` Slavomir Kaslev
2019-01-16 19:18 ` [PATCH 6/7] trace-cmd: Refactored make_instances() and tracecmd_remove_instances() Tzvetomir Stoyanov
2019-01-21 9:13 ` Steven Rostedt
2019-01-16 19:18 ` [PATCH 7/7] trace-cmd [POC]: Implemented timestamps synch PTP-like algorithm, using vsock events Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116191838.32127-4-tstoyanov@vmware.com \
--to=tstoyanov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).