From: Tzvetomir Stoyanov <tstoyanov@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v3 6/7] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM
Date: Fri, 8 Feb 2019 15:49:17 +0200 [thread overview]
Message-ID: <20190208134918.5618-7-tstoyanov@vmware.com> (raw)
In-Reply-To: <20190208134918.5618-1-tstoyanov@vmware.com>
In order to match host and guest events, a mapping between guest VCPU
and the host task, running this VCPU is needed. Extended existing
struct guest to hold such mapping and added logic in read_qemu_guests()
function to initialize it. Implemented a new internal API,
get_guest_vcpu_pids(), to retrieve VCPU-task mapping for given VM.
Signed-off-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
---
tracecmd/include/trace-local.h | 3 ++
tracecmd/trace-record.c | 57 +++++++++++++++++++++++++++++++++-
2 files changed, 59 insertions(+), 1 deletion(-)
diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h
index 8bf7c8e..4f6e239 100644
--- a/tracecmd/include/trace-local.h
+++ b/tracecmd/include/trace-local.h
@@ -233,6 +233,9 @@ void show_instance_file(struct buffer_instance *instance, const char *name);
int count_cpus(void);
+#define VCPUS_MAX 256
+int *get_guest_vcpu_pids(int cid);
+
/* No longer in event-utils.h */
void __noreturn die(const char *fmt, ...); /* Can be overriden */
void *malloc_or_die(unsigned int size); /* Can be overridden */
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index e1ad797..ab3f97e 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -2754,6 +2754,7 @@ struct guest {
char *name;
int cid;
int pid;
+ int cpu_pid[VCPUS_MAX];
};
static struct guest *guests;
@@ -2774,9 +2775,10 @@ static char *get_qemu_guest_name(char *arg)
static void read_qemu_guests(void)
{
static bool initialized;
+ struct dirent *entry_t;
struct dirent *entry;
char path[PATH_MAX];
- DIR *dir;
+ DIR *dir, *dir_t;
if (initialized)
return;
@@ -2832,6 +2834,49 @@ static void read_qemu_guests(void)
if (!is_qemu)
goto next;
+ snprintf(path, sizeof(path), "/proc/%s/task", entry->d_name);
+ dir_t = opendir(path);
+ if (dir_t) {
+ unsigned int vcpu;
+ char *buf = NULL;
+ char *cpu_str;
+ FILE *ft;
+ size_t n;
+ int j;
+
+ for (entry_t = readdir(dir_t); entry_t; entry_t = readdir(dir_t)) {
+ if (!(entry_t->d_type == DT_DIR &&
+ is_digits(entry_t->d_name)))
+ continue;
+ snprintf(path, sizeof(path),
+ "/proc/%s/task/%s/comm",
+ entry->d_name, entry_t->d_name);
+ ft = fopen(path, "r");
+ if (!ft)
+ continue;
+ getline(&buf, &n, ft);
+ if (buf && strncmp(buf, "CPU ", 4) == 0) {
+ cpu_str = buf;
+ while (*cpu_str != '\0' &&
+ isdigit(*cpu_str) == 0)
+ cpu_str++;
+ if (*cpu_str != '\0') {
+ j = 0;
+ while (cpu_str[j] != '\0' &&
+ isdigit(cpu_str[j]) != 0)
+ j++;
+ cpu_str[j] = '\0';
+ vcpu = atoi(cpu_str);
+ if (vcpu < VCPUS_MAX)
+ guest.cpu_pid[vcpu] = atoi(entry_t->d_name);
+ }
+ }
+ free(buf);
+ fclose(ft);
+ buf = NULL;
+ }
+ }
+
guests = realloc(guests, (guests_len + 1) * sizeof(*guests));
if (!guests)
die("Can not allocate guest buffer");
@@ -2877,6 +2922,16 @@ static char *parse_guest_name(char *guest, int *cid, int *port)
return guest;
}
+int *get_guest_vcpu_pids(int cid)
+{
+ int i;
+
+ for (i = 0; i < guests_len; i++)
+ if (cid == guests[i].cid)
+ return guests[i].cpu_pid;
+ return NULL;
+}
+
static void set_prio(int prio)
{
struct sched_param sp;
--
2.20.1
next prev parent reply other threads:[~2019-02-08 13:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 13:49 [PATCH v3 0/7][POC] trace-cmd: Timetamps sync using PTP-like algorithm, relying on vsock events Tzvetomir Stoyanov
2019-02-08 13:49 ` [PATCH v3 1/7] trace-cmd: Implemented new lib API: tracecmd_local_events_system() Tzvetomir Stoyanov
2019-02-08 13:49 ` [PATCH v3 2/7] trace-cmd: Added support for negative time offsets in trace.dat file Tzvetomir Stoyanov
2019-02-08 21:39 ` Steven Rostedt
2019-02-08 13:49 ` [PATCH v3 3/7] trace-cmd: Fixed logic in tracecmd_read_page_record() Tzvetomir Stoyanov
2019-02-08 22:08 ` Steven Rostedt
2019-02-08 13:49 ` [PATCH v3 4/7] trace-cmd: Added implementation of htonll() and ntohll() Tzvetomir Stoyanov
2019-02-08 13:49 ` [PATCH v3 5/7] trace-cmd: Refactored make_instances() and tracecmd_remove_instances() Tzvetomir Stoyanov
2019-02-08 22:11 ` Steven Rostedt
2019-02-08 22:44 ` Steven Rostedt
2019-02-08 22:46 ` Steven Rostedt
2019-02-08 13:49 ` Tzvetomir Stoyanov [this message]
2019-02-08 13:49 ` [PATCH v3 7/7] trace-cmd [POC]: Implemented timestamps synch PTP-like algorithm, using vsock events Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208134918.5618-7-tstoyanov@vmware.com \
--to=tstoyanov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).