From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
Yordan Karadzhov <ykaradzhov@vmware.com>
Subject: [PATCH 2/4] kernel-shark: Add dialog for user-defined plugin to the Tools menu
Date: Fri, 8 Mar 2019 19:14:03 +0200 [thread overview]
Message-ID: <20190308171405.15266-3-ykaradzhov@vmware.com> (raw)
In-Reply-To: <20190308171405.15266-1-ykaradzhov@vmware.com>
The dialog allows the user to find and load the plugin's
lobrary (.so file).
Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
---
kernel-shark/src/KsMainWindow.cpp | 20 ++++++++++++++++++++
kernel-shark/src/KsMainWindow.hpp | 4 ++++
2 files changed, 24 insertions(+)
diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
index 362b955..004c9ac 100644
--- a/kernel-shark/src/KsMainWindow.cpp
+++ b/kernel-shark/src/KsMainWindow.cpp
@@ -59,6 +59,7 @@ KsMainWindow::KsMainWindow(QWidget *parent)
_cpuSelectAction("CPUs", this),
_taskSelectAction("Tasks", this),
_pluginsAction("Plugins", this),
+ _addPluginAction("Add plugin", this),
_captureAction("Record", this),
_colorAction(this),
_colSlider(this),
@@ -233,6 +234,11 @@ void KsMainWindow::_createActions()
connect(&_pluginsAction, &QAction::triggered,
this, &KsMainWindow::_pluginSelect);
+ _addPluginAction.setStatusTip("Add plugin");
+
+ connect(&_addPluginAction, &QAction::triggered,
+ this, &KsMainWindow::_pluginAdd);
+
_captureAction.setIcon(QIcon::fromTheme("media-record"));
_captureAction.setShortcut(tr("Ctrl+R"));
_captureAction.setStatusTip("Capture trace data");
@@ -336,6 +342,7 @@ void KsMainWindow::_createMenus()
/* Tools menu */
tools = menuBar()->addMenu("Tools");
tools->addAction(&_pluginsAction);
+ tools->addAction(&_addPluginAction);
tools->addAction(&_captureAction);
tools->addSeparator();
tools->addAction(&_colorAction);
@@ -796,6 +803,19 @@ void KsMainWindow::_pluginSelect()
dialog->show();
}
+void KsMainWindow::_pluginAdd()
+{
+ QString fileName;
+
+ fileName = QFileDialog::getOpenFileName(this, "Add KernelShark plugin", KS_DIR,
+ "KernelShark Plugins (*.so);;");
+
+ if (fileName.isEmpty())
+ return;
+
+ _plugins.addPlugin(fileName);
+}
+
void KsMainWindow::_record()
{
#ifndef DO_AS_ROOT
diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp
index 969b603..a4eed19 100644
--- a/kernel-shark/src/KsMainWindow.hpp
+++ b/kernel-shark/src/KsMainWindow.hpp
@@ -132,6 +132,8 @@ private:
// Tools menu.
QAction _pluginsAction;
+ QAction _addPluginAction;
+
QAction _captureAction;
QWidgetAction _colorAction;
@@ -185,6 +187,8 @@ private:
void _pluginSelect();
+ void _pluginAdd();
+
void _record();
void _setColorPhase(int);
--
2.19.1
next prev parent reply other threads:[~2019-03-08 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 17:14 [PATCH 0/4] Add dialog for loading user-defined plugins Yordan Karadzhov
2019-03-08 17:14 ` [PATCH 1/4] kernel-shark: Define addPlugin method for KsPluginManager Yordan Karadzhov
2019-03-11 12:31 ` Slavomir Kaslev
2019-03-11 17:39 ` Yordan Karadzhov
2019-03-11 22:08 ` Steven Rostedt
2019-03-08 17:14 ` Yordan Karadzhov [this message]
2019-03-08 17:14 ` [PATCH 3/4] kernel-shark: Rename the manu action for managing registered plugins Yordan Karadzhov
2019-03-08 17:14 ` [PATCH 4/4] kernel-shark: Add icons for "Add plugin" and "Manage plugins" Yordan Karadzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308171405.15266-3-ykaradzhov@vmware.com \
--to=ykaradzhov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).