From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
Yordan Karadzhov <ykaradzhov@vmware.com>
Subject: [PATCH 3/4] kernel-shark: Rename the manu action for managing registered plugins
Date: Fri, 8 Mar 2019 19:14:04 +0200 [thread overview]
Message-ID: <20190308171405.15266-4-ykaradzhov@vmware.com> (raw)
In-Reply-To: <20190308171405.15266-1-ykaradzhov@vmware.com>
The menu action in Tools that is used to manage all registered
plugins is renamed in order to avoid confusion with the "Add plugin"
menu action, implemented in the previous patch.
Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
---
kernel-shark/src/KsMainWindow.cpp | 10 +++++-----
kernel-shark/src/KsMainWindow.hpp | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
index 004c9ac..f6889ca 100644
--- a/kernel-shark/src/KsMainWindow.cpp
+++ b/kernel-shark/src/KsMainWindow.cpp
@@ -58,7 +58,7 @@ KsMainWindow::KsMainWindow(QWidget *parent)
_clearAllFilters("Clear all filters", this),
_cpuSelectAction("CPUs", this),
_taskSelectAction("Tasks", this),
- _pluginsAction("Plugins", this),
+ _managePluginsAction("Manage plugins", this),
_addPluginAction("Add plugin", this),
_captureAction("Record", this),
_colorAction(this),
@@ -228,10 +228,10 @@ void KsMainWindow::_createActions()
this, &KsMainWindow::_taskSelect);
/* Tools menu */
- _pluginsAction.setShortcut(tr("Ctrl+P"));
- _pluginsAction.setStatusTip("Manage plugins");
+ _managePluginsAction.setShortcut(tr("Ctrl+P"));
+ _managePluginsAction.setStatusTip("Manage plugins");
- connect(&_pluginsAction, &QAction::triggered,
+ connect(&_managePluginsAction, &QAction::triggered,
this, &KsMainWindow::_pluginSelect);
_addPluginAction.setStatusTip("Add plugin");
@@ -341,7 +341,7 @@ void KsMainWindow::_createMenus()
/* Tools menu */
tools = menuBar()->addMenu("Tools");
- tools->addAction(&_pluginsAction);
+ tools->addAction(&_managePluginsAction);
tools->addAction(&_addPluginAction);
tools->addAction(&_captureAction);
tools->addSeparator();
diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp
index a4eed19..0727631 100644
--- a/kernel-shark/src/KsMainWindow.hpp
+++ b/kernel-shark/src/KsMainWindow.hpp
@@ -130,7 +130,7 @@ private:
QAction _taskSelectAction;
// Tools menu.
- QAction _pluginsAction;
+ QAction _managePluginsAction;
QAction _addPluginAction;
--
2.19.1
next prev parent reply other threads:[~2019-03-08 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 17:14 [PATCH 0/4] Add dialog for loading user-defined plugins Yordan Karadzhov
2019-03-08 17:14 ` [PATCH 1/4] kernel-shark: Define addPlugin method for KsPluginManager Yordan Karadzhov
2019-03-11 12:31 ` Slavomir Kaslev
2019-03-11 17:39 ` Yordan Karadzhov
2019-03-11 22:08 ` Steven Rostedt
2019-03-08 17:14 ` [PATCH 2/4] kernel-shark: Add dialog for user-defined plugin to the Tools menu Yordan Karadzhov
2019-03-08 17:14 ` Yordan Karadzhov [this message]
2019-03-08 17:14 ` [PATCH 4/4] kernel-shark: Add icons for "Add plugin" and "Manage plugins" Yordan Karadzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308171405.15266-4-ykaradzhov@vmware.com \
--to=ykaradzhov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).