From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: Slavomir Kaslev <slavomir.kaslev@gmail.com>,
"linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 1/4] kernel-shark: Define addPlugin method for KsPluginManager
Date: Mon, 11 Mar 2019 18:08:39 -0400 [thread overview]
Message-ID: <20190311180839.587fc269@oasis.local.home> (raw)
In-Reply-To: <3a983bd7-1c93-4bfe-8ead-ff98eefbc6a8@vmware.com>
On Mon, 11 Mar 2019 17:39:11 +0000
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> > Calling addPlugin() several times in a row will reinitialize all
> > already registered plugins several times and lead to quadratic
> > complexity. This seems wrong to me.
> >
> > Maybe we should split adding plugins from (re-)initializing them so
> > that one can add several plugins and then have initialized once when
> > they are actually needed to run. Wdyt?
> >
>
> Hi Slavi,
>
> KsPluginManager is a helper class for the GUI. It only does what the GUI
> is supposed to do. Currently the dialog that allows to load user plugins
> provides loading only one plugin at a time, so the KsPluginManager
> provides only this functionality.
>
> So the questions is: do we want a dialog that loads multiple plugins
> with one click?
What would be the issue with allowing that?
>
> On the other hand we do encourage the users to use the KernelShark
> library for making custom applications. This is the motivation for
> having the C API, but KsPluginManager it is not part of this API.
> KsPluginManager operates on top of the API and is intended to be used
> only by the GUI code.
>
> Indeed the C API itself separates adding plugins from there initializing.
Just like clicking the plugin dialog, where you select the plugins to
add or remove and hit apply. Couldn't this be the same, or am I missing
something?
-- Steve
next prev parent reply other threads:[~2019-03-11 22:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 17:14 [PATCH 0/4] Add dialog for loading user-defined plugins Yordan Karadzhov
2019-03-08 17:14 ` [PATCH 1/4] kernel-shark: Define addPlugin method for KsPluginManager Yordan Karadzhov
2019-03-11 12:31 ` Slavomir Kaslev
2019-03-11 17:39 ` Yordan Karadzhov
2019-03-11 22:08 ` Steven Rostedt [this message]
2019-03-08 17:14 ` [PATCH 2/4] kernel-shark: Add dialog for user-defined plugin to the Tools menu Yordan Karadzhov
2019-03-08 17:14 ` [PATCH 3/4] kernel-shark: Rename the manu action for managing registered plugins Yordan Karadzhov
2019-03-08 17:14 ` [PATCH 4/4] kernel-shark: Add icons for "Add plugin" and "Manage plugins" Yordan Karadzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311180839.587fc269@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=slavomir.kaslev@gmail.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).