From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: linux-trace-devel@vger.kernel.org, slavomir.kaslev@gmail.com
Subject: Re: [RFC PATCH v8 13/13] trace-cmd: Add VM tracing over FIFOs transport
Date: Tue, 12 Mar 2019 15:28:19 -0400 [thread overview]
Message-ID: <20190312152819.3eae7941@gandalf.local.home> (raw)
In-Reply-To: <20190222180539.27439-14-kaslevs@vmware.com>
On Fri, 22 Feb 2019 20:05:39 +0200
Slavomir Kaslev <kaslevs@vmware.com> wrote:
> FIFOs offer ~3x the throughput of vsockets. This patch adds support for using
> FIFOs to stream tracing data back to the host when tracing VMs.
>
> Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
> ---
> include/trace-cmd/trace-cmd.h | 8 ++--
> tracecmd/include/trace-local.h | 4 +-
> tracecmd/trace-agent.c | 40 ++++++++++++++--
> tracecmd/trace-msg.c | 26 ++++++----
> tracecmd/trace-record.c | 87 ++++++++++++++++++++++++++++++----
> 5 files changed, 137 insertions(+), 28 deletions(-)
>
> diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h
> index 52962e9..27ba89d 100644
> --- a/include/trace-cmd/trace-cmd.h
> +++ b/include/trace-cmd/trace-cmd.h
> @@ -333,16 +333,16 @@ bool tracecmd_msg_done(struct tracecmd_msg_handle *msg_handle);
> void tracecmd_msg_set_done(struct tracecmd_msg_handle *msg_handle);
>
> int tracecmd_msg_send_trace_req(struct tracecmd_msg_handle *msg_handle,
> - int argc, char **argv);
> + int argc, char **argv, bool use_fifos);
> int tracecmd_msg_recv_trace_req(struct tracecmd_msg_handle *msg_handle,
> - int *argc, char ***argv);
> + int *argc, char ***argv, bool *use_fifos);
>
> int tracecmd_msg_send_trace_resp(struct tracecmd_msg_handle *msg_handle,
> int nr_cpus, int page_size,
> - unsigned int *ports);
> + unsigned int *ports, bool use_fifos);
> int tracecmd_msg_recv_trace_resp(struct tracecmd_msg_handle *msg_handle,
> int *nr_cpus, int *page_size,
> - unsigned int **ports);
> + unsigned int **ports, bool *use_fifos);
Hmm, maybe flags would be good to keep. We can put "use_fifos" in the
flags field of the ports being passed across.
-- Steve
>
> /* --- Plugin handling --- */
> extern struct tep_plugin_option trace_ftrace_options[];
> diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h
> index d32ba88..d7bdb1f 100644
next prev parent reply other threads:[~2019-03-12 19:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 18:05 [RFC PATCH v8 00/13] Add VM kernel tracing over vsockets and FIFOs Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 01/13] trace-cmd: Minor cleanup in tracecmd_start_recording() Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 02/13] trace-cmd: Minor cleanup in print_stat() Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 03/13] trace-cmd: Detect if vsockets are available Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 04/13] trace-cmd: Add tracecmd_create_recorder_virt function Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 05/13] trace-cmd: Add TRACE_REQ and TRACE_RESP messages Slavomir Kaslev
2019-02-22 21:09 ` Steven Rostedt
2019-03-12 18:48 ` Slavomir Kaslev
2019-03-12 19:18 ` Steven Rostedt
2019-02-22 18:05 ` [RFC PATCH v8 06/13] trace-cmd: Add buffer instance flags for tracing in guest and agent context Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 07/13] trace-cmd: Add VM kernel tracing over vsockets transport Slavomir Kaslev
2019-03-12 19:23 ` Steven Rostedt
2019-03-12 23:07 ` Steven Rostedt
2019-02-22 18:05 ` [RFC PATCH v8 08/13] trace-cmd: Use splice(2) for vsockets if available Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 09/13] trace-cmd: Add `trace-cmd setup-guest` command Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 10/13] trace-cmd: Try to autodetect number of guest CPUs in setup-guest if not specified Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 11/13] trace-cmd: Add setup-guest flag for attaching FIFOs to the guest VM config Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 12/13] trace-cmd: Add splice() recording from FIFO without additional pipe buffer Slavomir Kaslev
2019-02-22 18:05 ` [RFC PATCH v8 13/13] trace-cmd: Add VM tracing over FIFOs transport Slavomir Kaslev
2019-03-12 19:28 ` Steven Rostedt [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-02 13:42 [RFC PATCH v8 00/11] Add VM kernel tracing over vsockets and FIFOs Slavomir Kaslev
2019-04-02 13:42 ` [RFC PATCH v8 13/13] trace-cmd: Add VM tracing over FIFOs transport Slavomir Kaslev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312152819.3eae7941@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=slavomir.kaslev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).