From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=BXa2=RQ=vger.kernel.org=linux-trace-devel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A3C86C43381
	for <linux-trace-devel@archiver.kernel.org>; Wed, 13 Mar 2019 17:36:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 7399C2146E
	for <linux-trace-devel@archiver.kernel.org>; Wed, 13 Mar 2019 17:36:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726336AbfCMRgA (ORCPT
        <rfc822;linux-trace-devel@archiver.kernel.org>);
        Wed, 13 Mar 2019 13:36:00 -0400
Received: from mail.kernel.org ([198.145.29.99]:51622 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726097AbfCMRgA (ORCPT
        <rfc822;linux-trace-devel@vger.kernel.org>);
        Wed, 13 Mar 2019 13:36:00 -0400
Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 4CB892075C;
        Wed, 13 Mar 2019 17:35:59 +0000 (UTC)
Date:   Wed, 13 Mar 2019 13:35:57 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Tzvetomir Stoyanov <tstoyanov@vmware.com>
Cc:     linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v4 21/46] tools/lib/traceevent: Man pages
 tep_get_first_event() and tep_get_events_count()
Message-ID: <20190313133557.0eb47cfa@gandalf.local.home>
In-Reply-To: <20190308133654.21264-22-tstoyanov@vmware.com>
References: <20190308133654.21264-1-tstoyanov@vmware.com>
        <20190308133654.21264-22-tstoyanov@vmware.com>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-trace-devel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-trace-devel.vger.kernel.org>
X-Mailing-List: linux-trace-devel@vger.kernel.org

On Fri,  8 Mar 2019 15:36:29 +0200
Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:

> +#include <event-parse.h>
> +...
> +struct tep_handle *tep = tep_alloc();
> +...
> +int i,count = tep_get_events_count(tep);
> +struct tep_event *event, *events = tep_get_first_event(tep);
> +
> +if (events == NULL) {
> +	/* There are no events */
> +} else {
> +	for (i=0; i<count; i++) {

The examples should follow Linux coding style ;-)

That is, tabs and not spaces, and space out the for:

	for (i = 0; i < count; i++) {

-- Steve

> +		event = (events+i);
> +		/* process events[i] */
> +	}
> +}