From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B13AC10F00 for ; Mon, 18 Mar 2019 20:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6997320872 for ; Mon, 18 Mar 2019 20:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727269AbfCRUxM (ORCPT ); Mon, 18 Mar 2019 16:53:12 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:35418 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727132AbfCRUxM (ORCPT ); Mon, 18 Mar 2019 16:53:12 -0400 Received: from patrickm (unknown [100.42.98.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: chutzpah) by smtp.gentoo.org (Postfix) with ESMTPSA id 45F24335CC8; Mon, 18 Mar 2019 20:53:11 +0000 (UTC) Date: Mon, 18 Mar 2019 13:53:08 -0700 From: Patrick McLean To: Steven Rostedt Cc: Yordan Karadzhov , linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v2 1/3] kernel-shark: Reorder the priority when searching for trace-cmd libs Message-ID: <20190318135308.6f3c902f@patrickm> In-Reply-To: <20190318144709.3551d48b@gandalf.local.home> References: <20190313152220.22026-1-ykaradzhov@vmware.com> <20190313152220.22026-2-ykaradzhov@vmware.com> <20190313114235.7fc6ce3b@patrickm> <20190318144709.3551d48b@gandalf.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Mon, 18 Mar 2019 14:47:09 -0400 Steven Rostedt wrote: > On Wed, 13 Mar 2019 11:42:35 -0700 > Patrick McLean wrote: > > > On Wed, 13 Mar 2019 17:22:18 +0200 > > Yordan Karadzhov wrote: > > > > > The CMAKE build system of KernelShark performs automated search > > > for the trace-cmd libraries, headers and executable before > > > building the GUI. The new order of the list of directories to > > > search in is the following: > > > > > > 1. ${TRACE_CMD}/ ($TRACE_CMD is an environment variable) > > > > > > 2. CMAKE_SOURCE_DIR/../ > > > > > > 3. Platform / system specific locations > > > > > > > For system installs (especially when trace-cmd and trace-cmd are > > separate packages), it's nicer to have trace-cmd install a pkgconfig > > file. Then the kernelshark can cmake use pkgconfig for getting the > > build options to find the headers, libraries, and binaries. > > > > See https://people.freedesktop.org/~dbn/pkg-config-guide.html for > > documentation on pkgconfig and pkgconfig files. > > Patrick, > > Are you OK if I pull these patches in for now, and we sort out the > configurations later? I was holding this off, but found that some of > Yordan's other patches are dependent on this. > That's fine, my suggestions are more for long-term than an immediate need. Most distros will probably work with the generic locations anyway.