From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: Tzvetomir Stoyanov <tstoyanov@vmware.com>,
"linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v7 6/9] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM
Date: Tue, 19 Mar 2019 12:49:14 -0400 [thread overview]
Message-ID: <20190319124914.43ddec4b@gandalf.local.home> (raw)
In-Reply-To: <CAE0o1NtR+bEXYUP_suHJMfAXnXmtSPPMzSZrunoP5mp5VeNL_A@mail.gmail.com>
On Tue, 19 Mar 2019 16:35:28 +0000
Slavomir Kaslev <kaslevs@vmware.com> wrote:
> > +
> > + snprintf(path, sizeof(path), "/proc/%s/task", guest_task);
> > + dir = opendir(path);
> > + if (!dir)
> > + return;
> > +
> > + for (entry_t = readdir(dir); entry_t; entry_t = readdir(dir)) {
>
> Nit: `while ((entry = readdir(dir))) {` is more common throughout the code.
Agreed. Although in a lot of cases I prefer for() over while(), in this
case, when the initialization is identical to the next iteration, the
while() is preferred.
-- Steve
next prev parent reply other threads:[~2019-03-19 16:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 15:55 [PATCH v7 0/9] trace-cmd: Timetamps sync between host and guest machines, relying on vsock events Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 1/9] trace-cmd: Implemented new lib API: tracecmd_local_events_system() Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 2/9] trace-cmd: Added support for negative time offsets in trace.dat file Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 3/9] trace-cmd: Fix tracecmd_read_page_record() to read more than one event Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 4/9] trace-cmd: Added implementation of htonll() and ntohll() Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 5/9] trace-cmd: Refactored few functions in trace-record.c Tzvetomir Stoyanov
2019-03-19 18:21 ` Matt Helsley
2019-03-20 14:14 ` Tzvetomir Stoyanov
2019-03-20 14:35 ` Steven Rostedt
2019-03-21 15:06 ` Tzvetomir Stoyanov
2019-03-21 20:52 ` Steven Rostedt
2019-03-19 15:55 ` [PATCH v7 6/9] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM Tzvetomir Stoyanov
2019-03-19 16:35 ` Slavomir Kaslev
2019-03-19 16:49 ` Steven Rostedt [this message]
2019-03-19 15:55 ` [PATCH v7 7/9] trace-cmd: Implemented new API tracecmd_add_option_v() Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 8/9] trace-cmd: Implemented new option in trace.dat file: TRACECMD_OPTION_TIME_SHIFT Tzvetomir Stoyanov
2019-03-19 17:58 ` Slavomir Kaslev
2019-03-19 18:00 ` Slavomir Kaslev
2019-03-20 14:39 ` Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 9/9] trace-cmd [POC]: Implemented timestamps synch algorithm, using vsock events Tzvetomir Stoyanov
2019-03-19 17:14 ` Slavomir Kaslev
2019-03-19 17:51 ` Steven Rostedt
2019-03-19 18:02 ` Slavomir Kaslev
2019-03-19 18:29 ` Matt Helsley
2019-03-19 18:40 ` Steven Rostedt
2019-03-20 15:06 ` Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319124914.43ddec4b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).