From: Tzvetomir Stoyanov <tstoyanov@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v7 3/9] trace-cmd: Fix tracecmd_read_page_record() to read more than one event
Date: Tue, 19 Mar 2019 17:55:30 +0200 [thread overview]
Message-ID: <20190319155536.19381-4-tstoyanov@vmware.com> (raw)
In-Reply-To: <20190319155536.19381-1-tstoyanov@vmware.com>
The kbuffer_next_event() will return the next event on the sub buffer.
If we pass in the last_record to tracecmd_read_page_record(), it
initializes the sub buffer, and by calling kbuffer_next_event()
(instead of kbuffer_read_event()), the second event on the sub buffer
is returned. This causes the match of the last_record not to match if
the last_record happens to be the first event on the sub buffer.
Signed-off-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
---
lib/trace-cmd/trace-input.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index be6720c..0a6e820 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -1679,18 +1679,22 @@ tracecmd_read_page_record(struct tep_handle *pevent, void *page, int size,
goto out_free;
}
- do {
+ ptr = kbuffer_read_event(kbuf, &ts);
+ while (ptr < last_record->data) {
ptr = kbuffer_next_event(kbuf, NULL);
if (!ptr)
break;
- } while (ptr < last_record->data);
+ if (ptr == last_record->data)
+ break;
+ }
if (ptr != last_record->data) {
warning("tracecmd_read_page_record: could not find last_record");
goto out_free;
}
- }
+ ptr = kbuffer_next_event(kbuf, &ts);
+ } else
+ ptr = kbuffer_read_event(kbuf, &ts);
- ptr = kbuffer_read_event(kbuf, &ts);
if (!ptr)
goto out_free;
--
2.20.1
next prev parent reply other threads:[~2019-03-19 15:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 15:55 [PATCH v7 0/9] trace-cmd: Timetamps sync between host and guest machines, relying on vsock events Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 1/9] trace-cmd: Implemented new lib API: tracecmd_local_events_system() Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 2/9] trace-cmd: Added support for negative time offsets in trace.dat file Tzvetomir Stoyanov
2019-03-19 15:55 ` Tzvetomir Stoyanov [this message]
2019-03-19 15:55 ` [PATCH v7 4/9] trace-cmd: Added implementation of htonll() and ntohll() Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 5/9] trace-cmd: Refactored few functions in trace-record.c Tzvetomir Stoyanov
2019-03-19 18:21 ` Matt Helsley
2019-03-20 14:14 ` Tzvetomir Stoyanov
2019-03-20 14:35 ` Steven Rostedt
2019-03-21 15:06 ` Tzvetomir Stoyanov
2019-03-21 20:52 ` Steven Rostedt
2019-03-19 15:55 ` [PATCH v7 6/9] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM Tzvetomir Stoyanov
2019-03-19 16:35 ` Slavomir Kaslev
2019-03-19 16:49 ` Steven Rostedt
2019-03-19 15:55 ` [PATCH v7 7/9] trace-cmd: Implemented new API tracecmd_add_option_v() Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 8/9] trace-cmd: Implemented new option in trace.dat file: TRACECMD_OPTION_TIME_SHIFT Tzvetomir Stoyanov
2019-03-19 17:58 ` Slavomir Kaslev
2019-03-19 18:00 ` Slavomir Kaslev
2019-03-20 14:39 ` Tzvetomir Stoyanov
2019-03-19 15:55 ` [PATCH v7 9/9] trace-cmd [POC]: Implemented timestamps synch algorithm, using vsock events Tzvetomir Stoyanov
2019-03-19 17:14 ` Slavomir Kaslev
2019-03-19 17:51 ` Steven Rostedt
2019-03-19 18:02 ` Slavomir Kaslev
2019-03-19 18:29 ` Matt Helsley
2019-03-19 18:40 ` Steven Rostedt
2019-03-20 15:06 ` Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319155536.19381-4-tstoyanov@vmware.com \
--to=tstoyanov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).