From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Cc: Matt Helsley <mhelsley@vmware.com>,
"linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 3/3] tools/lib/traceevent: Implement new traceevent APIs for accessing struct tep_handler fields
Date: Thu, 21 Mar 2019 08:59:40 -0400 [thread overview]
Message-ID: <20190321085940.33bf7566@gandalf.local.home> (raw)
In-Reply-To: <CACqStofWc3178z+2bk_LTSfcZ=Q2y8PDtWmr9yeDxOuBus=CBw@mail.gmail.com>
On Thu, 21 Mar 2019 10:03:22 +0000
Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:
> This one is a little bit confusing, there are two different APIs:
> int tep_host_bigendian(void) - used in perf, checks the byte order of
> the local machine
> int tep_is_host_bigendian(struct tep_handle *pevent) - checks the
> order, stored in the tep_handler
>
> I remember that we discussed this with Steven last year, and decided
> to keep both of them. I'm not
> aware of all use cases, and what is the purpose of tep_is_host_bigendian() API ?
Yes, there's history to these names. I'll take a look at them and see
how they can change to something less confusing.
-- Steve
next prev parent reply other threads:[~2019-03-21 12:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 11:19 [PATCH 0/3] Few patches, related to libtracevent APIs Tzvetomir Stoyanov
2019-03-19 11:19 ` [PATCH 1/3] tools/lib/traceevent: Change description of few APIs Tzvetomir Stoyanov
2019-03-20 15:48 ` Matt Helsley
2019-03-19 11:19 ` [PATCH 2/3] tools/lib/traceevent: Coding style fixes Tzvetomir Stoyanov
2019-03-20 15:53 ` Matt Helsley
2019-03-19 11:19 ` [PATCH 3/3] tools/lib/traceevent: Implement new traceevent APIs for accessing struct tep_handler fields Tzvetomir Stoyanov
2019-03-20 16:32 ` Matt Helsley
2019-03-21 9:26 ` Tzvetomir Stoyanov
2019-03-21 10:03 ` Tzvetomir Stoyanov
2019-03-21 12:59 ` Steven Rostedt [this message]
2019-03-21 19:24 ` Steven Rostedt
2019-03-21 19:46 ` Steven Rostedt
2019-03-22 11:33 ` Tzvetomir Stoyanov
2019-03-22 12:16 ` Steven Rostedt
2019-03-22 12:49 ` Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321085940.33bf7566@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mhelsley@vmware.com \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).