From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark
Date: Wed, 27 Mar 2019 09:07:14 -0400 [thread overview]
Message-ID: <20190327090714.6ab0e534@gandalf.local.home> (raw)
In-Reply-To: <6424edde-820e-a6a0-ac4e-cacf8c225652@vmware.com>
On Wed, 27 Mar 2019 08:58:20 +0000
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> Yes, this makes sense. I will make the application creating the
> .cache/kernelshark directory if it doesn't exist.
>
> But do I need to remove the creation of directory in the build process?
Yes, please remove it. A build process shouldn't modify directories
outside the build directory unless specifically told to do so (like
make install).
-- Steve
next prev parent reply other threads:[~2019-03-27 13:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 15:22 [PATCH v2 0/3] Tuning the KernelShark build system Yordan Karadzhov
2019-03-13 15:22 ` [PATCH v2 1/3] kernel-shark: Reorder the priority when searching for trace-cmd libs Yordan Karadzhov
2019-03-13 18:42 ` Patrick McLean
2019-03-13 19:06 ` Steven Rostedt
2019-03-13 20:32 ` Patrick McLean
2019-03-18 18:47 ` Steven Rostedt
2019-03-18 20:53 ` Patrick McLean
2019-03-26 12:58 ` Steven Rostedt
2019-03-26 13:35 ` Yordan Karadzhov (VMware)
2019-03-26 13:57 ` Steven Rostedt
2019-03-27 0:24 ` Patrick McLean
2019-03-26 15:08 ` Steven Rostedt
2019-03-13 15:22 ` [PATCH v2 2/3] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark Yordan Karadzhov
2019-03-26 20:51 ` Steven Rostedt
2019-03-27 8:58 ` Yordan Karadzhov
2019-03-27 13:07 ` Steven Rostedt [this message]
2019-03-13 15:22 ` [PATCH v2 3/3] kernel-shark: Set the configuration cache directory via env. variable Yordan Karadzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327090714.6ab0e534@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).