From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: linux-trace-devel@vger.kernel.org, slavomir.kaslev@gmail.com
Subject: Re: [RFC PATCH v9 01/11] trace-cmd: Make ports unsigned int
Date: Wed, 3 Apr 2019 09:00:02 -0400 [thread overview]
Message-ID: <20190403090002.75119b51@gandalf.local.home> (raw)
In-Reply-To: <20190402134540.32321-2-kaslevs@vmware.com>
On Tue, 2 Apr 2019 16:45:30 +0300
Slavomir Kaslev <kaslevs@vmware.com> wrote:
> -static int write_ints(char *buf, size_t buf_len, int *arr, int arr_len)
> +static unsigned int atou(const char *s)
> +{
> + long r;
> +
> + r = atol(s);
> + if (r >= 0 && r <= UINT_MAX)
> + return r;
> +
> + return 0;
> +}
> +
I wonder if we should do this instead:
/* test a to u */
static int tatou(const char *s, int *res)
{
long r;
r = atol(s);
if (r >= 0 && r <= UINT_MAX) {
*res = (unsigned)r;
return 0;
}
return -1;
}
That way we could check for invalid ints.
-- Steve
next prev parent reply other threads:[~2019-04-03 13:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 13:45 [RFC PATCH v9 00/11] Add VM kernel tracing over vsockets and FIFOs Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 01/11] trace-cmd: Make ports unsigned int Slavomir Kaslev
2019-04-03 13:00 ` Steven Rostedt [this message]
2019-04-03 13:14 ` Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 02/11] trace-cmd: Detect if vsockets are available Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 03/11] trace-cmd: Add tracecmd_create_recorder_virt function Slavomir Kaslev
2019-04-03 13:02 ` Steven Rostedt
2019-04-03 13:12 ` Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 04/11] trace-cmd: Add TRACE_REQ and TRACE_RESP messages Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 05/11] trace-cmd: Add buffer instance flags for tracing in guest and agent context Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 06/11] trace-cmd: Add VM kernel tracing over vsockets transport Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 07/11] trace-cmd: Use splice(2) for vsockets if available Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 08/11] trace-cmd: Add `trace-cmd setup-guest` command Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 09/11] trace-cmd: Try to autodetect number of guest CPUs in setup-guest if not specified Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 10/11] trace-cmd: Add setup-guest flag for attaching FIFOs to the guest VM config Slavomir Kaslev
2019-04-02 13:45 ` [RFC PATCH v9 11/11] trace-cmd: Add splice() recording from FIFO without additional pipe buffer Slavomir Kaslev
2019-04-03 12:55 ` Steven Rostedt
2019-04-03 13:11 ` Slavomir Kaslev
2019-04-03 13:16 ` Slavomir Kaslev
2019-04-03 13:25 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403090002.75119b51@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=slavomir.kaslev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).