From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org, Darren Hart <darren@dvhart.com>
Subject: Re: [PATCH 03/10] tools lib traceevent: Removed unneeded !! and return parenthesis
Date: Fri, 5 Apr 2019 10:31:11 -0400 [thread overview]
Message-ID: <20190405103111.77593cde@gandalf.local.home> (raw)
In-Reply-To: <20190405140332.10949-4-tstoyanov@vmware.com>
On Fri, 5 Apr 2019 17:03:25 +0300
Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> As return is not a function we do not need parenthesis around the return
> value. Also, a function returning bool does not need to add !!.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Tzvetomir Stoyanov <tstoyanov@vmware.com>
> Link: https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Flkml.kernel.org%2Fr%2F20190401164343.817886725%40goodmis.org&data=02%7C01%7Ctstoyanov%40vmware.com%7C420f58a3ff864e3d93b408d6b7853daf%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636898180235384820&sdata=PTx4BKspBlUxHIPfzZRf2Rj5J8LmfzXxdCIXKdDUtoA%3D&reserved=0
Hmm, this isn't acceptable for upstream.
-- Steve
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
next prev parent reply other threads:[~2019-04-05 14:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 14:03 [PATCH 00/10] Backport of traceevent APIs cleanup changes from kernel tree to trace-cmd Tzvetomir Stoyanov
2019-04-05 14:03 ` [PATCH 01/10] tools lib traceevent: Change description of few APIs Tzvetomir Stoyanov
2019-04-05 14:03 ` [PATCH 02/10] tools lib traceevent: Implement new traceevent APIs for accessing struct tep_handler fields Tzvetomir Stoyanov
2019-04-05 14:03 ` [PATCH 03/10] tools lib traceevent: Removed unneeded !! and return parenthesis Tzvetomir Stoyanov
2019-04-05 14:31 ` Steven Rostedt [this message]
2019-04-05 14:03 ` [PATCH 04/10] tools lib traceevent: Remove tep filter trivial APIs Tzvetomir Stoyanov
2019-04-05 14:03 ` [PATCH 05/10] tools lib traceevent: Remove call to exit() from tep_filter_add_filter_str() Tzvetomir Stoyanov
2019-04-05 14:03 ` [PATCH 06/10] tools tools, tools lib traceevent: Make traceevent APIs more consistent Tzvetomir Stoyanov
2019-04-05 14:03 ` [PATCH 07/10] tools lib traceevent: Rename input arguments of libtraceevent APIs from pevent to tep Tzvetomir Stoyanov
2019-04-05 14:03 ` [PATCH 08/10] perf tools, tools lib traceevent: Rename "pevent" member of struct tep_event to "tep" Tzvetomir Stoyanov
2019-04-05 14:03 ` [PATCH 09/10] perf tools, tools lib traceevent: Rename "pevent" member of struct tep_event_filter " Tzvetomir Stoyanov
2019-04-05 14:03 ` [PATCH 10/10] tools lib traceevent: Rename input arguments and local variables of libtraceevent from pevent to tep Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405103111.77593cde@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=darren@dvhart.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).