From: Phil Auld <pauld@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org,
Yordan Karadzhov <ykaradzhov@vmware.com>,
Josef Bacik <jbacik@fb.com>,
Tzvetomir Stoyanov <tstoyanov@vmware.com>,
Slavomir Kaslev <kaslevs@vmware.com>
Subject: Re: trace-cmd fails with many cpus
Date: Fri, 12 Apr 2019 14:13:13 -0400 [thread overview]
Message-ID: <20190412181313.GA11355@lorien.usersys.redhat.com> (raw)
In-Reply-To: <20190412113547.31b08902@gandalf.local.home>
On Fri, Apr 12, 2019 at 11:35:47AM -0400 Steven Rostedt wrote:
> On Fri, 12 Apr 2019 11:15:46 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > >
> > >
> > > I suppose the answer is don't run on a system with that many cpus :)
> > >
> > > But I wonder if it would be possible to have the threads each handle say 8 cpu
> > > files or something.
> >
> > Actually, I think another solution is to consolidate the pids that are
> > to be excluded and sort them. Thus if we have (which is very likely the
> > case)
> >
> > (common_pid!=1000)&&(common_pid!=1001)&&(common_pid!=1002)
> >
> > That we change that to:
> >
> > !((common_pid>=1000)||(common_pid<=1002))
>
> > > WRITE: /sys/kernel/tracing/events/sched/sched_switch/filter, len 6718, data "(common_pid!=100199)&&(common_pid!=100198)&&(common_pid!=100197)&&(common_pid!=100196)&&(common_pid!=100195)&&(common_pid!=100194)&&(common_pid!=100193)&&(common_pid!=100192)&&(common_pid!=100191) ... 160 of these ...
> > > &&(common_pid!=100040)||(next_pid!=100199)&&(next_pid!=100198)&&(next_pid!=100197)&&(next_pid!=100196)&&(next_pid!=100195)&&(next_pid!=100194)&&(next_pid!=100193)&&(next_pid!=100192)... 160 of these...
>
> Yes this would definitely help. From your output that is shown, we
> could convert that to:
>
> !((common_pid>=100040)||(common_pid<=100199))&&!((next_pid>=100040)||(next_pid<=100199))
>
That'll be interesting to code given how the code works now, but does look
like it would help. Probably save a lot of instructions when filtering too.
Thanks for looking at it.
I can just find a smaller machine.
Cheers,
Phil
>
> -- Steve
--
next prev parent reply other threads:[~2019-04-12 18:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 13:53 trace-cmd fails with many cpus Phil Auld
2019-04-12 15:15 ` Steven Rostedt
2019-04-12 15:35 ` Steven Rostedt
2019-04-12 18:13 ` Phil Auld [this message]
2019-04-12 18:39 ` Steven Rostedt
2019-04-12 18:51 ` Steven Rostedt
2019-04-12 23:01 ` [PATCH] Slavomir Kaslev
2019-04-12 23:01 ` [PATCH] Slavomir Kaslev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412181313.GA11355@lorien.usersys.redhat.com \
--to=pauld@redhat.com \
--cc=jbacik@fb.com \
--cc=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tstoyanov@vmware.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).