From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,UPPERCASE_50_75, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 357F7C10F0E for ; Fri, 12 Apr 2019 19:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BF382171F for ; Fri, 12 Apr 2019 19:47:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726936AbfDLTr6 (ORCPT ); Fri, 12 Apr 2019 15:47:58 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:42349 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbfDLTr6 (ORCPT ); Fri, 12 Apr 2019 15:47:58 -0400 Received: by mail-io1-f65.google.com with SMTP id c4so9529587ioh.9 for ; Fri, 12 Apr 2019 12:47:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eytJCn/M3BPr+VLE9KRBg1wy49E1CvxwwjDmWVTBmUc=; b=CiZyJ+vaPGdjE/xeU3L6j0lP0Iilc9IKa6hUEy3Um9l5IqcFGomkGdp7zHbrOVxu2z KSaZtxDTSJKSFz3SYh70lbFJ22Ut9aw5bTvj600WqHyEYcCTox7K+/KkWEKlILLrYAEv PUZXEoz4Op93ZB34E/DFVEhqc3YX0+du8zHmxaiZ9qEqEcZEDhiRBXaGSRjsJvNdRXqt gTvhHRt+5JjY0QJKpBacJjWo89E6jTcHLV3xrtKevOg88t2N3oFmfB5T9vVFIYbOIotN Wyh56hjD+J+jB2uHnl713MjapdK3sWrVod/ZJWuMamlH0WRpEMwk7UfoM+sSICWJSc57 32lw== X-Gm-Message-State: APjAAAUT9X7A+glo/tzOyna3fHHf/7ZEJlx026N8ByKORjjhIzeUPJkt N04ZS7p28MmGgJl+s32Sg9Iy6w== X-Google-Smtp-Source: APXvYqycmA3Fwn4qflLxtQbMn7VL2CKTf2bzrk6uD+LoRj5JQol55d9h1F9lAgr68K+DoOFzO9xIMQ== X-Received: by 2002:a5d:91d2:: with SMTP id k18mr29630462ior.24.1555098477717; Fri, 12 Apr 2019 12:47:57 -0700 (PDT) Received: from google.com ([2620:15c:183:0:20b8:dee7:5447:d05]) by smtp.gmail.com with ESMTPSA id c25sm15366576ioa.75.2019.04.12.12.47.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 12 Apr 2019 12:47:56 -0700 (PDT) Date: Fri, 12 Apr 2019 13:47:52 -0600 From: Raul Rangel To: Steven Rostedt Cc: linux-trace-devel@vger.kernel.org, eballetbo@gmail.com, zwisler@chromium.org, djkurtz@chromium.org, Enric Balletbo i Serra , Guenter Roeck , linux-kernel@vger.kernel.org, Benson Leung Subject: Re: [PATCH v2] chrome/platform: cros_ec_proto:: Add trace event to trace EC commands Message-ID: <20190412194752.GA238393@google.com> References: <20190412184944.125338-1-rrangel@chromium.org> <20190412150438.56ba4429@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190412150438.56ba4429@gandalf.local.home> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Fri, Apr 12, 2019 at 03:04:38PM -0400, Steven Rostedt wrote: > On Fri, 12 Apr 2019 12:49:44 -0600 > Raul E Rangel wrote: > > > +#define ec_cmds \ > > + {EC_CMD_PROTO_VERSION, "PROTO_VERSION"}, \ > > + {EC_CMD_HELLO, "HELLO"}, \ > > + {EC_CMD_GET_VERSION, "GET_VERSION"}, \ > > + {EC_CMD_READ_TEST, "READ_TEST"}, \ > > + {EC_CMD_GET_BUILD_INFO, "GET_BUILD_INFO"}, \ > > + {EC_CMD_GET_CHIP_INFO, "GET_CHIP_INFO"}, \ > > + {EC_CMD_GET_BOARD_VERSION, "GET_BOARD_VERSION"}, \ > > + {EC_CMD_READ_MEMMAP, "READ_MEMMAP"}, \ > > + {EC_CMD_GET_CMD_VERSIONS, "GET_CMD_VERSIONS"}, \ > > + {EC_CMD_GET_COMMS_STATUS, "GET_COMMS_STATUS"}, \ > > + {EC_CMD_TEST_PROTOCOL, "TEST_PROTOCOL"}, \ > > + {EC_CMD_GET_PROTOCOL_INFO, "GET_PROTOCOL_INFO"}, \ > > + {EC_CMD_GSV_PAUSE_IN_S5, "GSV_PAUSE_IN_S5"}, \ > > + {EC_CMD_GET_FEATURES, "GET_FEATURES"}, \ > > Usually, if I have something like this, I would do: > > > #define ec_cmds \ > EC(PROTO_VERSION), \ > EC(HELLO), \ > EC(GET_VERSION), \ > EC(READ_TEST), \ > [...] > > Then: > > #define EC(a) {EC_CMD_##a, #a} > > and then ec_cmds ends up with the same result with much less typing and > little risk for copy past errors. I generally don't like doing that because it breaks my editors Goto Definition, but I can send out a patch that uses the macro. Thanks, Raul > > -- Steve