From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2130DC10F13 for ; Tue, 16 Apr 2019 13:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D957420675 for ; Tue, 16 Apr 2019 13:04:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="eMBoAjAK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728650AbfDPNEq (ORCPT ); Tue, 16 Apr 2019 09:04:46 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:38545 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727240AbfDPNEq (ORCPT ); Tue, 16 Apr 2019 09:04:46 -0400 Received: by mail-qt1-f195.google.com with SMTP id d13so23135229qth.5 for ; Tue, 16 Apr 2019 06:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dyyODE0ttOiq2JOet6neCffQ3LW3uGHaT76cMdNhKQU=; b=eMBoAjAKEC2QPSkTtDC6zvFgkqallSe5jceNRkvWTHVIv0/CzW/7FA1R+eGoa7gVTr k8Mz1DmnuNoJN4ufsTxFiCwyOYbxTT1yYgm7cnF4SIi17fgl7gYwV3YF1xyyqZXdfI4f SGbGuBkJ8D2PgdfISiUuWqNPS1+V6K83Kjkm0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dyyODE0ttOiq2JOet6neCffQ3LW3uGHaT76cMdNhKQU=; b=kCXnrwluKDVhMWG1u65izSVwt9STp8rlX9jLm1N9TPqbKrtkn+H8OqZKT2xl93BuF1 f+4hwTsY9llFWOdsRzLqCCw6mruFFYTApj7TkoHgUkjOkJdinkAjcO3KtbjxXtG94vwQ h2qLeuOb8BBeLKRjW4CxrpWTzH1DKx+AKb/GvvVfskWsGN9sn0C6nB19nuAn4V2EZflC gGe6sTptb2iFSOoAAVksPD3Kf+14hIWDkVw4fwpuaArCUbkH40c2oYowEkGZPxKQWCMq 08TzpEcomvc+OpXuU/vhhDbux8tu+lLP0Q63iNANhWWf0R0grADEyB4OWcWMt0f+DVz9 F6qw== X-Gm-Message-State: APjAAAX1fdYKzHwzUnfT/Dpp3oaWR3UpDgPDAfLxoWPN2O2SEpooNZdr WGO6Cwfgb2sdPBTo2lvfAT8XUQ== X-Google-Smtp-Source: APXvYqyZ3MqAhTolVZpGfpu1m/BSpRdSq8K4VmKrQqrbquHpwonTER/JgjiaLdXnjqn3OwEM7gL1MQ== X-Received: by 2002:a0c:b5d0:: with SMTP id o16mr65052800qvf.187.1555419884823; Tue, 16 Apr 2019 06:04:44 -0700 (PDT) Received: from localhost ([2600:1003:b45e:46c8:3e5b:dc27:4ea5:df4a]) by smtp.gmail.com with ESMTPSA id x28sm34955986qtx.71.2019.04.16.06.04.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 06:04:43 -0700 (PDT) Date: Tue, 16 Apr 2019 13:04:40 +0000 From: Joel Fernandes To: Greg Kroah-Hartman Cc: Steven Rostedt , Kees Cook , Olof Johansson , Alexei Starovoitov , Joel Fernandes , Linux Kernel Mailing List , Qais Yousef , Dietmar Eggemann , Manoj Rao , Andrew Morton , Alexei Starovoitov , atish patra , Daniel Colascione , Dan Williams , Guenter Roeck , Jonathan Corbet , Karim Yaghmour , Android Kernel Team , "open list:DOCUMENTATION" , "open list:KERNEL SELFTEST FRAMEWORK" , linux-trace-devel@vger.kernel.org, Masahiro Yamada , Masami Hiramatsu , Randy Dunlap , Shuah Khan , Yonghong Song Subject: Re: [PATCH v5 1/3] Provide in-kernel headers to make extending kernel easier Message-ID: <20190416130440.GA7944@localhost> References: <20190408203601.GF133872@google.com> <20190411031540.ehezr6kq7ouobpzx@ast-mbp.dhcp.thefacebook.com> <20190415104109.64d914f3@gandalf.local.home> <20190416083306.5646a687@gandalf.local.home> <20190416124939.GB6027@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190416124939.GB6027@kroah.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Tue, Apr 16, 2019 at 02:49:39PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 16, 2019 at 08:33:06AM -0400, Steven Rostedt wrote: > > On Mon, 15 Apr 2019 22:50:10 -0500 > > Kees Cook wrote: > > > > > On Mon, Apr 15, 2019 at 9:41 AM Steven Rostedt wrote: > > > > I agree with this assessment. We shouldn't use config.gz as precedence > > > > for this solution. config.gz should have been in debugfs to begin with, > > > > but I don't believe debugfs was around when config.gz was introduced. > > > > (Don't have time to look into the history of the two). > > > > > > I don't agree with this: /proc/config.gz is used by a lot of tools > > > that do sanity-check of running systems. This isn't _debugging_... > > > it's verifying correct kernel builds. It's a fancy version of checking > > > /proc/version. > > > > > > > Then we should perhaps make a new file system call tarballs ;-) > > > > /sys/kernel/tarballs/ > > > > and place everything there. That way it removes it from /proc (which is > > the worse place for that) and also makes it something other than debug. > > That's what I did for tracefs. > > As horrible as that suggestion is, it does kind of make sense :) > > We can't put this in debugfs as that's only for debugging and systems > should never have that mounted for normal operations (users want to > build ebpf programs), and /proc really should be for processes but that > horse is long left the barn. > > But, I'm willing to consider putting this either in a system-fs-like > filesystem, or just in sysfs itself, we do have /sys/kernel/ to play > around in if the main objection is that we should not be cluttering up > /proc with stuff like this. > I am ok with the suggestion of /sys/kernel for the archive. That also seems to fit well with the idea that the headers are kernel related and probably belong here more strictly speaking, than /proc. thanks, - Joel > thanks, > > greg k-h