Re: [PATCH v3 0/2] Optimize pid filters and add --no-filter option

[Phil Auld <pauld@redhat.com>]

On Tue, Apr 16, 2019 at 02:00:14AM +0300 Slavomir Kaslev wrote:
> This patchset optimizes how pid filters are expressed and makes it less likely
> that we overflow ftrace filters' size limit of one page.
> 
> Changes since v2:
> 
> Append exclude rules with &&
> 
> Changes since v1:
> 
> Add missing tags
> Fix append_filter_pid_range() callers to pass valid range as [min,max]
> 
> 
> Slavomir Kaslev (2):
>   trace-cmd: Optimize how pid filters are expressed
>   trace-cmd: Add --no-filter option to not filter recording processes
> 
>  tracecmd/trace-record.c | 131 ++++++++++++++++++++++++++++------------
>  tracecmd/trace-usage.c  |   1 +
>  2 files changed, 92 insertions(+), 40 deletions(-)
> 
> -- 
> 2.19.1
> 


This version is also working for my use case.  The logic in the filter
does show the recording thread pids in the sched switch event, at least 
when switching to/from a non-excluded process.  But I think that's 
desired.

The --no-filter option works as expected.


Acked-by: Phil Auld <pauld@redhat.com>


Thanks,
Phil
--