From: Phil Auld <pauld@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Slavomir Kaslev <kaslevs@vmware.com>,
linux-trace-devel@vger.kernel.org, ykaradzhov@vmware.com,
jbacik@fb.com, tstoyanov@vmware.com, slavomir.kaslev@gmail.com
Subject: Re: [PATCH v3 0/2] Optimize pid filters and add --no-filter option
Date: Tue, 16 Apr 2019 20:29:10 -0400 [thread overview]
Message-ID: <20190417002910.GA9705@lorien.usersys.redhat.com> (raw)
In-Reply-To: <20190416173909.7b1ff01f@gandalf.local.home>
On Tue, Apr 16, 2019 at 05:39:09PM -0400 Steven Rostedt wrote:
> On Tue, 16 Apr 2019 09:22:54 -0400
> Phil Auld <pauld@redhat.com> wrote:
>
> > This version is also working for my use case. The logic in the filter
> > does show the recording thread pids in the sched switch event, at least
> > when switching to/from a non-excluded process. But I think that's
> > desired.
> >
> > The --no-filter option works as expected.
> >
> >
> > Acked-by: Phil Auld <pauld@redhat.com>
> >
>
> Could we get a Tested-by: from you for this series?
The second one for sure. I did it both with and without and
saw the difference.
I was not comfortable with that for the first because I really
only tested it in my setup on one machine (160 cpus). I didn't do
really thorough testing. If that's enough for you then sure :)
Tested-by: Phil Auld <pauld@redhat.com>
Cheers,
Phil
>
> Thanks!
>
> -- Steve
--
next prev parent reply other threads:[~2019-04-17 0:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 23:00 [PATCH v3 0/2] Optimize pid filters and add --no-filter option Slavomir Kaslev
2019-04-15 23:00 ` [PATCH v3 1/2] trace-cmd: Optimize how pid filters are expressed Slavomir Kaslev
2019-04-16 21:48 ` Steven Rostedt
2019-04-17 13:44 ` Slavomir Kaslev
2019-04-15 23:00 ` [PATCH v3 2/2] trace-cmd: Add --no-filter option to not filter recording processes Slavomir Kaslev
2019-04-16 21:49 ` Steven Rostedt
2019-04-16 13:22 ` [PATCH v3 0/2] Optimize pid filters and add --no-filter option Phil Auld
2019-04-16 21:39 ` Steven Rostedt
2019-04-17 0:29 ` Phil Auld [this message]
2019-04-17 12:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417002910.GA9705@lorien.usersys.redhat.com \
--to=pauld@redhat.com \
--cc=jbacik@fb.com \
--cc=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=slavomir.kaslev@gmail.com \
--cc=tstoyanov@vmware.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).