Re: [PATCH v4 2/2] trace-cmd: Document record --no-filter option in record's man page

[Steven Rostedt <rostedt@goodmis.org>]

On Wed, 17 Apr 2019 16:09:59 +0300
Slavomir Kaslev <kaslevs@vmware.com> wrote:

> Add a section about the new --no-filter argument of `trace-cmd record`
> to its man page.
> 
> Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
> ---
>  Documentation/trace-cmd-record.1.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/trace-cmd-record.1.txt b/Documentation/trace-cmd-record.1.txt
> index 68afa16..b230aa8 100644
> --- a/Documentation/trace-cmd-record.1.txt
> +++ b/Documentation/trace-cmd-record.1.txt
> @@ -83,6 +83,10 @@ OPTIONS
>  
>      The above are usually safe to use to compare fields.
>  
> +*--no-filter*::
> +    Do not set any event filters, including the default one which ignores events
> +    caused by trace-cmd itself.

Actually, this is wrong and so is the help message.

It should be:

  *--no-filter*::
	Do not filter out the trace-cmd threads. By default, the
	threads are filtered out to not be traced by events. This
	option will have the trace-cmd threads also be traced.

And the help message should be:

 # trace-cmd record -h
  [..]
  --no-filter include trace-cmd threads in the trace

Want to resend this patch and also fix the help message (assume it is
applied).

Thanks!

-- Steve

> +
>  *-R* 'trigger'::
>      Specify a trigger for the previous event. This must come after a *-e*. 
>      This will add a given trigger to the given event. To only enable the trigger