From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: linux-trace-devel@vger.kernel.org, pauld@redhat.com,
ykaradzhov@vmware.com, jbacik@fb.com, tstoyanov@vmware.com,
slavomir.kaslev@gmail.com
Subject: Re: [PATCH v4 2/2] trace-cmd: Document record --no-filter option in record's man page
Date: Wed, 17 Apr 2019 12:24:15 -0400 [thread overview]
Message-ID: <20190417122415.1435829f@gandalf.local.home> (raw)
In-Reply-To: <20190417121908.2e244706@gandalf.local.home>
On Wed, 17 Apr 2019 12:19:08 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> Actually, this is wrong and so is the help message.
>
> It should be:
>
> *--no-filter*::
> Do not filter out the trace-cmd threads. By default, the
> threads are filtered out to not be traced by events. This
> option will have the trace-cmd threads also be traced.
>
> And the help message should be:
>
> # trace-cmd record -h
> [..]
> --no-filter include trace-cmd threads in the trace
>
> Want to resend this patch and also fix the help message (assume it is
> applied).
Actually, I just pushed an update to upstream. Could you just combine
this and the --no-filter patch, and update both help messages.
That is, I didn't apply the --no-filter patch.
Thanks!
-- Steve
prev parent reply other threads:[~2019-04-17 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 13:09 [PATCH v4 0/2] Optimize pid filters Slavomir Kaslev
2019-04-17 13:09 ` [PATCH v4 1/2] trace-cmd: Optimize how pid filters are expressed Slavomir Kaslev
2019-04-17 13:58 ` Phil Auld
2019-04-17 14:18 ` John Kacur
2019-04-17 14:25 ` Phil Auld
2019-04-17 14:52 ` Steven Rostedt
2019-04-17 14:52 ` Steven Rostedt
2019-04-17 14:54 ` Steven Rostedt
2019-04-17 13:09 ` [PATCH v4 2/2] trace-cmd: Document record --no-filter option in record's man page Slavomir Kaslev
2019-04-17 14:05 ` Phil Auld
2019-04-17 16:19 ` Steven Rostedt
2019-04-17 16:24 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417122415.1435829f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jbacik@fb.com \
--cc=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=pauld@redhat.com \
--cc=slavomir.kaslev@gmail.com \
--cc=tstoyanov@vmware.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).