From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org, y.karadz@gmail.com
Subject: Re: [PATCH v3 4/8] kernel-shark: Add logic for the plugins search path
Date: Fri, 19 Apr 2019 13:28:15 -0400 [thread overview]
Message-ID: <20190419132815.2820b6af@gandalf.local.home> (raw)
In-Reply-To: <20190419135036.19340-5-ykaradzhov@vmware.com>
On Fri, 19 Apr 2019 16:50:32 +0300
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> +char *KsPluginManager::_pluginLibFromName(const QString &plugin, int &n)
> +{
> + QString path = QCoreApplication::applicationFilePath();
> + std::string pluginStr = plugin.toStdString();
> + char *lib;
> +
> + if (path.contains(KS_DIR)) {
I'd rather not use the hardcoded path. If I build the code on one
machine, tarball it up and move it to another machine and extract it,
and then run that code from that machine, I want it to still use the
plugins for that machine.
I was hoping to test:
string = cmdline_path() + "../../kernel-shark/lib/";
If that exists, then we know that we are in the source directory.
-- Steve
> + n = asprintf(&lib, "%s/lib/plugin-%s.so",
> + KS_DIR, pluginStr.c_str());
> + } else {
> + n = asprintf(&lib, "%s/lib/kshark/plugins/plugin-%s.so",
> + _INSTALL_PREFIX, pluginStr.c_str());
> + }
> +
> + return lib;
> +}
> +
next prev parent reply other threads:[~2019-04-19 18:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 13:50 [PATCH v3 0/8] Various modifications and fixes toward KS 1.0 Yordan Karadzhov
2019-04-19 13:50 ` [PATCH v3 1/8] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark Yordan Karadzhov
2019-04-19 13:50 ` [PATCH v3 2/8] kernel-shark: Remove the definition of KS_CONF_DIR Yordan Karadzhov
2019-04-19 13:50 ` [PATCH v3 3/8] kernel-shark: Add logic for the initial path of Open-File dialogs Yordan Karadzhov
2019-04-19 16:23 ` Steven Rostedt
2019-04-19 13:50 ` [PATCH v3 4/8] kernel-shark: Add logic for the plugins search path Yordan Karadzhov
2019-04-19 17:28 ` Steven Rostedt [this message]
2019-04-22 11:29 ` Yordan Karadzhov (VMware)
2019-04-22 11:50 ` Steven Rostedt
2019-04-22 12:21 ` Yordan Karadzhov (VMware)
2019-04-19 13:50 ` [PATCH v3 5/8] kernel-shark: Rename KS_DIR to KS_SOURCE_DIR Yordan Karadzhov
2019-04-19 13:50 ` [PATCH v3 6/8] kernel-shark: Load Last Session from command line Yordan Karadzhov
2019-04-19 18:16 ` Steven Rostedt
2019-04-19 13:50 ` [PATCH v3 7/8] kernel-shark: Use proper searching condition when the dataset is small Yordan Karadzhov
2019-04-19 13:50 ` [PATCH v3 8/8] kernel-shark: Handle the case when the marker points to a filtered entry Yordan Karadzhov
2019-04-19 18:13 ` [PATCH v3 0/8] Various modifications and fixes toward KS 1.0 Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419132815.2820b6af@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).